edgetx icon indicating copy to clipboard operation
edgetx copied to clipboard

LUA - model.setFlightMode() problem with trimValue #8373 on OpenTX

Open lshems opened this issue 4 years ago • 6 comments

So we need to have some guidance here.

So what do we do with OpenTX bugs, probably not solved in OPenTX, like the above?

I would rather shoot on a moving target, than trying to pull a dead horse. But its up to you guys.

lshems avatar May 17 '21 20:05 lshems

https://github.com/opentx/opentx/issues/8373

lshems avatar May 17 '21 20:05 lshems

@lshems We started EdgeTX to do something different and test new things, so why not changing these kind of things, if it makes sense to everyone?

Would you be so kind to edit your description to include the description of the problem itself? Including a test script would be just great! (nothing fancy, just 2-3 lines showing the issue).

raphaelcoeffic avatar May 18 '21 07:05 raphaelcoeffic

Oh, lovely... the can increase but can't decrease trims lua bug... nice feature, that one! 😆 🤮

pfeerick avatar May 18 '21 10:05 pfeerick

Ok, two issues:

One: if you provide only one table element, it will not update the values, as the current implementation runs over the switches 0-4 of the input provided, so if you ommit input 1, it will not even start updating the values.

Two: it is not correctly interpreting the new value, probably due to a type conversion error (integer to long, ... ???) this results in working only for sitive values, never for negative.

lshems avatar May 21 '21 21:05 lshems

I will provide a script example this weekend, with some pseudo code on what it does now, and some pseudo code on how it should work in my opinion.

lshems avatar May 21 '21 21:05 lshems

I will provide a script example this weekend, with some pseudo code on what it does now, and some pseudo code on how it should work in my opinion.

Is this still an issue?

gagarinlg avatar Sep 17 '22 06:09 gagarinlg

Closed, because of missing feedback

gagarinlg avatar Feb 25 '23 20:02 gagarinlg

I'm not sure it should be closed. The info is given in the opentx link.

I'll see if can make the script to show the error.

lshems avatar Feb 26 '23 17:02 lshems