edgetx icon indicating copy to clipboard operation
edgetx copied to clipboard

feature(backlight): obsolete SF and allow for assigning a knob

Open raphaelcoeffic opened this issue 1 year ago • 18 comments

Fixes #1844 Fixes #1637 Fixes #418 Fixes #53

Summary of changes:

  • Special Function "Backlight" obsoleted
  • Added a Source parameter to the backlight settings (in Radio Setup).

raphaelcoeffic avatar Aug 31 '22 08:08 raphaelcoeffic

Potential Bug/Confusion - because the special function has been ripped out, any prior configs now will substitute the trainer SF (although it is disabled).

General functionality seems to be working fine. Can we have the ON brightness slider update when the source is moved (when defined)? Since without looking at the code isn't this what the source is effectively changing?

This then just needs Companion support. And do we also crash the Volume party as well (in another PR!!) for double the complaints? :grin:

pfeerick avatar Sep 04 '22 10:09 pfeerick

Volume would be nice. Then it would br complete. Maybe better to break it in one pr

Eldenroot avatar Sep 05 '22 14:09 Eldenroot

And do we also crash the Volume party as well (in another PR!!) for double the complaints? 😁

Why not 😋

raphaelcoeffic avatar Sep 05 '22 15:09 raphaelcoeffic

@raphaelcoeffic will you extend this to volume as well please?

Eldenroot avatar Sep 27 '22 07:09 Eldenroot

Move this to 2.9 and stick with final WiP PRs and bugfixes?

pfeerick avatar Sep 27 '22 08:09 pfeerick