edgetx icon indicating copy to clipboard operation
edgetx copied to clipboard

R9M access: fix subtype

Open raphaelcoeffic opened this issue 3 years ago • 6 comments

Fixes #1585

Summary of changes:

  • do not send a sub-type for PXX2 R9M modules

raphaelcoeffic avatar Aug 15 '22 12:08 raphaelcoeffic

@brainbubblersbest Would you care to do the honours and confirm this finally puts this to rest? :grin:

pfeerick avatar Aug 15 '22 12:08 pfeerick

Oh yes. There's nothing Im waiting for more. 😄

brainbubblersbest avatar Aug 15 '22 18:08 brainbubblersbest

I just realised that a custom firmware (with -DHARDWARE_EXTERNAL_ACCESS_MOD=YES) needs to be compiled to be able to test, so here is a set of test firmware for TX16S, X10 (regular) and X12S: pr2211-test-firmwares.zip

raphaelcoeffic avatar Aug 24 '22 09:08 raphaelcoeffic

16616026190214535478226564474575 16616026586984914432484178707188 16616027127426267552290425721742

Maybe one thing at least. On opentx with flex firmware, (if I remember right) the Automatic Power Level was somehow declared? Can anyone check this? I just hear from the louder buzzing that the power regulation is active working.

And is that normal that I got telemetry lost/recovered when in the module firmware versions menu?

Ill test dual receiver configuration now.

brainbubblersbest avatar Aug 27 '22 12:08 brainbubblersbest

@brainbubblersbest this PR is aimed at fixing #1585. So the question here is: does it? We really need to separate issues and not clutter issues/PRs with all sort of other findings. If there is anything to be checked/tracked, it should probably be in another issue.

raphaelcoeffic avatar Aug 28 '22 05:08 raphaelcoeffic

Ill check that.

brainbubblersbest avatar Aug 28 '22 09:08 brainbubblersbest