edgetx
edgetx copied to clipboard
EdgeTX
Add BETAFPV LiteRadio3 Pro radio target.
Add BETAFPV LiteRadio3 Pro radio. https://betafpv.com/products/literadio-3-pro-radio-transmitter
Companion looks okay so far. Simulator:
- lcd display needs to fit to background image
- could not see how to manipulate both 5D buttons to mirror radio functionality
Background image updated. @elecpower
@zhaobing-byte please rebase your work on top of the current main. Also, while rebasing, you should get rid of unnecessary changes / commits. You should not have any merge commits appearing in the commit list. We expect to see only commits that implement something, and no "merge from..." or anything like that.
@zhaobing-byte Please don't try to resolve conflicts by new commits - rebase the branch on the current state of main, or do a merge commit if you must. Or ping me or one of the other devs to do it for you if you need it done. I'll rebase this again shortly to remove the conflicts.
@gagarinlg This would be worth having a look over when you get a chance since I think you have the hardware?
@zhaobing-byte Please don't try to resolve conflicts by new commits - rebase the branch on the current state of main, or do a merge commit if you must. Or ping me or one of the other devs to do it for you if you need it done. I'll rebase this again shortly to remove the conflicts.
@gagarinlg This would be worth having a look over when you get a chance since I think you have the hardware?
I will give it a try and report back. I will not be able to test the RF stuff beyond binding a receiver, because I have ELRS receviers, but nothing to connect to them, yet, and I have no nano module to test the module bay.
I will give it a try and report back. I will not be able to test the RF stuff beyond binding a receiver, because I have ELRS receviers, but nothing to connect to them, yet, and I have no nano module to test the module bay.
Thanks for that :) Just a basic - "nothing looks broken" test (since we're talking ELRS, you should be able to interact with Lua and also get telemetry) will be great since the code - it's up to BetaFPV to do more rigorous testing since the radio code looks ok, and Neil was happy with the Companion side.
@zhaobing-byte Can you double check the latest build/state of this PR, with the goal of getting this merged this week. I've pushed a couple more minor changes, rebased it against the current main branch, and done some minor cleanup on the way.
Flashing the ELRS module via USB Serial pass through works. Using the ELRS Lua script works Binding a reciever and getting RSSI works
Model settings are not stored, though. It looks like the YAML code generator as to be rerun. Keys, switches and trims work
Perfect timing... I was just fixing something else... it's a wonder the build system didn't have a fit... would you mind checking the settings save again please? :)
Perfect timing... I was just fixing something else... it's a wonder the build system didn't have a fit... would you mind checking the settings save again please? :)
Model settings are now persistent again.
As a more general question, does it make sense to have this radio have the heli tab enabled in the default builds?
Given the likely audience for this radio, probably not (and because that now sounds like a double negative, I agree - it makes sense to hide the screen!). If we were to do it I would probably do it in the build_gh.sh script. Hopefully when #1692 becomes a thing, this can also be done for B&W also. At least for B&W targets that don't need it to be removed due to size constraints.