edgetx icon indicating copy to clipboard operation
edgetx copied to clipboard

Opening TBS Agent Lite Wifi setting hangs the radio

Open flyhigh-hifi opened this issue 3 years ago • 17 comments

Is there an existing issue for this problem?

  • [X] I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

I had working(slowly but working) wifi system to connect phone with MicroTX V2 module on OpenTX, now moved to edgeTX and if I try to go to Agent Lite lua script(v0.96) and open XF Wifi settings - whole radio hangs(sticks are working but no way to change the screen - holding exit button doesn't help). I'm not sure whether issue is in tbs lua script or edgeTX, but it shouldn't hang at least.

Expected Behavior

Expecting to have working tbs agent lite.

Steps To Reproduce

  1. Install tbs agent lite 0.96
  2. bind radio
  3. open lua script(XF Wifi setting)
  4. ...

Version

2.7.0

Transmitter

FrSky X9D+2019

Anything else?

No response

flyhigh-hifi avatar Apr 29 '22 17:04 flyhigh-hifi

Is your Crossfire module WiFi firmware version above 2.0?

JimB40 avatar Apr 30 '22 05:04 JimB40

Is your Crossfire module WiFi firmware version above 2.0?

Forgot to mention, yes, latest one v6.17 firmware

flyhigh-hifi avatar Apr 30 '22 08:04 flyhigh-hifi

Crossfire firmware and WiFi module inside transmitter are two different firmwares. So you can have 6.17 firmware for Crossfire but still WiFi firmware is 1.XX which is incompatible with Agent Lite 0.96 and you need latest 2.XX As now you can't check wifi firmware version via Agent Lite (it hangs) use prcedure described here: https://team-blacksheep.freshdesk.com/support/solutions/articles/4000161703-tbs-crossfire-update-the-wifi-module-

JimB40 avatar May 08 '22 19:05 JimB40

I am seeing similar issues with Agent Lite after choosing WiFi module and General menu option. This only happens when background scripts are running such as the yaapu script. It hangs after displaying the first line of the General screen when it opens up. If I run this t before swiping to load the yaapu full screen widget, then agent lite works as expected. There is a suggestion in RCG thread that this is lua related (and specifically only started in recent release of ETx since 2.6 - this bug not in current OTx release), where background telemetry scripts are not being suspended when a new foreground script is launched causing the foreground script to hang (or in the case of the yaapu script, re-initialise continually). This is the post from Alex/Yaapu: https://www.rcgroups.com/forums/showpost.php?p=49110363&postcount=2593

I posted about the Yaapu script here: https://www.rcgroups.com/forums/showpost.php?p=49170383&postcount=840

YT vid showing the issue with yaapu script here: https://youtu.be/Uy4Wk4VddpA

athertop avatar May 14 '22 23:05 athertop

for ELRS it works with edge 2.6 but lua script is getting CSRF packet sooo slowly. After official 2.6 it is not working any more. I'm wondering if there is a link with this PR

urlu75 avatar May 16 '22 09:05 urlu75

Crossfire firmware and WiFi module inside transmitter are two different firmwares. So you can have 6.17 firmware for Crossfire but still WiFi firmware is 1.XX which is incompatible with Agent Lite 0.96 and you need latest 2.XX As now you can't check wifi firmware version via Agent Lite (it hangs) use prcedure described here: https://team-blacksheep.freshdesk.com/support/solutions/articles/4000161703-tbs-crossfire-update-the-wifi-module-

Confirming that this fixed my TX being blocked by lua script and tbs script/wifi section works fine after update. Thanks.

flyhigh-hifi avatar May 20 '22 15:05 flyhigh-hifi

Confirming that this fixed my TX being blocked by lua script and tbs script/wifi section works fine after update. Thanks.

But do you run the Yaapu telemetry script/widget? If so, display the yaapu widget screen then push sys and launch the tbs agent lite and see how it has issues because of conflicting use of telemetry.

Sorry, but I might have latched onto your reported issue here thinking it was related to the telemetry conflict problem that exists in ETx 2.7 or newer. If your issue is truly resolved and nothing to do with the telemetry problem, then I should probably open a new ticket. Please advise. Thanks

athertop avatar May 20 '22 15:05 athertop

Executing LUA script in stand-alone mode should stop all other scripts including widgets. @jfrickmann have you been changing anything in this area?

JimB40 avatar May 20 '22 16:05 JimB40

No, not as far as I know! ———————— Jesper Frickmann

Den 20. maj 2022 kl. 12.12 skrev Robert @.***>:



Executing LUA script in stand-alone mode should stop all other scripts including widgets. @jfrickmannhttps://github.com/jfrickmann have you been changing anything in this area?

— Reply to this email directly, view it on GitHubhttps://github.com/EdgeTX/edgetx/issues/1917#issuecomment-1133083396, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AD4WPG5YZB2P4KZM75D7FKTVK62WHANCNFSM5UWV7KYA. You are receiving this because you were mentioned.Message ID: @.***>

jfrickmann avatar May 20 '22 16:05 jfrickmann

It worked fine on 2.6 but seeing issues since 2.7 so something appears to have been introduced to cause this

athertop avatar May 20 '22 18:05 athertop

Can confirm, running the Yaapu script will kill anything that uses crsf telemetry from the TOOLS. Either painfully slow or not working at all, as if they're competing for the crsf_pop_telemetry calls.

jonas-koeritz avatar May 23 '22 08:05 jonas-koeritz

For people with mk2 tx16s, it comes with edgetx 2.6,but it has this problem. I just reload the firmware 2.6 from this site. Turns out they are not the same because the problem is gone now.

lai573 avatar May 30 '22 15:05 lai573

But then the problem reappeared in 2.7.1

athertop avatar May 30 '22 17:05 athertop

I have exactly the same issue with TBS agent lite and yaapu script. With models running Yaapu widget at background TBS agent lite freezes during loading data for rx and does not find and load Micro TX at all as a viewable option. As i change to an other model without Yaapu widget setup...TBS agen lite works as it should. Radiomaster tx16 mark 2 edgetx 2.7.1 (same issue existed with 2.6 edge tx as the radio was supplied) Yaapu 1.96 dev TBS agent lite 0.96 TBS FW 6.14 tx and rx Any suggestion or new version for edgetx or yaapu which fixes this bug?

Ltomi78 avatar Sep 04 '22 11:09 Ltomi78

For people with mk2 tx16s, it comes with edgetx 2.6,but it has this problem. I just reload the firmware 2.6 from this site. Turns out they are not the same because the problem is gone now.

I can confirm that my brand new tx16 mark2 comes with 2.6edgetx has this issue when yaapu selected for a certaim model tbs agent lite freeze or just not load the data

Ltomi78 avatar Sep 04 '22 11:09 Ltomi78

Probably similar to two comments above, the version of edgetx shipped was probably not the release version of 2.6, but a nightly build. It's easy to check - what's the release date shown in Radio Settings => Version? Is it "2022-01-24" (2.6 was released on 24 Jan 2022). If not, you could try flashing the proper 2.6 release build.

There are likely to be two different issues present here - as B&W radios (like the initial poster) are very different to colorlcd radios in how they and Lua work. For colorlcd radios, we should be stopping widgets when you're in the settings, but it appears possible we aren't atm, which is why the combination of yappu + TBS agent lite is problematic, as they are both trying to talk to the crossfire module at the same time.

pfeerick avatar Sep 04 '22 11:09 pfeerick

Thanks for your feedback. I ve reflashed the stock supplied version of 2.6.0...its an early version from 2021 12.20..so not the one you mentioned. But now with this 2021 version of 2.6.0 the tbs agent lite started to working along with yaapu widget :) a little bit slow but finds micro TX also. I will check it with the version from 2022.01.24 how its behave. Thx :) But thats true with 2.7.1 the issue exist. 20220904_141757 20220904_142331

Probably similar to two comments above, the version of edgetx shipped was probably not the release version of 2.6, but a nightly build. It's easy to check - what's the release date shown in Radio Settings => Version? Is it "2022-01-24" (2.6 was released on 24 Jan 2022). If not, you could try flashing the proper 2.6 release build.

There are likely to be two different issues present here - as B&W radios (like the initial poster) are very different to colorlcd radios in how they and Lua work. For colorlcd radios, we should be stopping widgets when you're in the settings, but it appears possible we aren't atm, which is why the combination of yappu + TBS agent lite is problematic, as they are both trying to talk to the crossfire module at the same time.

Ltomi78 avatar Sep 04 '22 12:09 Ltomi78

Any news if this issue with tbs agent lite and other scripts using crsf telemetry at the same time will be fixed in 2.8.0?

Ltomi78 avatar Oct 04 '22 10:10 Ltomi78

I would love to hear this answer as I'm finding it difficult using crossfire with EdgeTX. Could one of the devs please advise if this issue is now resolved? I do not see any recent commit for this

athertop avatar Oct 04 '22 11:10 athertop

I would love to hear this answer as I'm finding it difficult using crossfire with EdgeTX. Could one of the devs please advise if this issue is now resolved? I do not see any recent commit for this

Agree maybe it would be nice if @yaapu Alex can take part in the examination what causing this issue. Yaapu script works well but seems its overriding TBS Agent lite which freezing down.

Ltomi78 avatar Oct 04 '22 11:10 Ltomi78

It's not the yaapu script specifically causing this. It would happen with any telemetry widget. It's that EdgeTX is not pausing the widget scripts when you open tools scripts, so both are fighting/conflicting over the telemetry feed. It works fine in Opentx and did in an earlier version of ETx also. So something has been introduced to cause this issue

athertop avatar Oct 04 '22 12:10 athertop

Agree thanks for clarifying...and i coud not force to stop that scrip without deleting it

Ltomi78 avatar Oct 04 '22 13:10 Ltomi78

@flyhigh-hifi I wonder if it might be an idea to rename this issue to maybe get it better noticed? I was thinking something like "Tools scripts hang if telemetry widgets active". Just an idea as the issue does not only relate to TBS scripts

athertop avatar Oct 05 '22 14:10 athertop

@flyhigh-hifi I wonder if it might be an idea to rename this issue to maybe get it better noticed? I was thinking something like "Tools scripts hang if telemetry widgets active". Just an idea as the issue does not only relate to TBS scripts

Good idea!

Ltomi78 avatar Oct 09 '22 12:10 Ltomi78

Gentlemen, has anyone tested this with the latest 2.8.0 release candidate? I believe the issue should be gone, as no method from the LUA widgets are called while in a standalone LUA script.

raphaelcoeffic avatar Oct 10 '22 16:10 raphaelcoeffic

tested with 2.8RC2 rebuild with BT=ON and GPS=OFF. ELRSv2 script now perfectly run with yaapu set up. Issue seems to be gone, thanks !

urlu75 avatar Oct 10 '22 19:10 urlu75

I was going to say I'm not so sure... but I think there is something else afoot here - it could be that the yaapu telemetry widget is still being serviced when going into TBS AgentX lite, or there is some other timing weirdness - it seemed more apparent when I had just added the widget, than when powering on with a configured model. i.e. I opened TBS Agent Lite, and it was blank, opened up ELRS and it was busy loading for about 15 seconds, and then all of a sudden started slowly pulling in the data and was fine after that. Went back to TBS Agent, and it was fine also. And upon restarting the radio, was generally immediately responsive. So I think we can safely call this basically fixed, but there could be some edge case weirdness to keep an eye out for (although I half expect another PR that is already waiting might have some impact on that).

pfeerick avatar Oct 11 '22 02:10 pfeerick

I tested 2.8rc3 tonight with yaapu script and tbs agent lite. Working perfectly now. First time I have been able to use these properly since adopting ETx. Well done guys. Can't wait for the final release. Best regards

athertop avatar Oct 30 '22 23:10 athertop

Thanks for your feedback..cant wait to test it on my radio too

Ltomi78 avatar Oct 30 '22 23:10 Ltomi78