edgetx icon indicating copy to clipboard operation
edgetx copied to clipboard

Cosmetics: uniform usage of "MPM"

Open rotorman opened this issue 3 years ago • 2 comments

Uniform usage of "MPM" for Multi-Protocol-Module instead of mixing "MULTI" and "MULTIMODULE". Makes it easier to search for MPM related keywords, as MULTI is used also for other designators in code (e.g. MULTIPOS).

rotorman avatar Jan 23 '22 18:01 rotorman

I like! Consistency is good :)

pfeerick avatar Jan 24 '22 01:01 pfeerick

Some more work will be needed on this, as you can't just change the enum_ModuleType values in conversions/yaml and yaml, since this invalidates current settings (and potentially conversions as I'm not sure of the implications of changing the setting there).

Regardless, a model that was previously working and had the MPM enabled will no longer have it enabled, as a result of this PR, so this is not a backwards compatible change. I think this would need a stub that can discriminate between the two on read, or this triggers yet another conversion, since you're changing the config file format. @raphaelcoeffic ?

pfeerick avatar Jan 29 '22 01:01 pfeerick