buddy icon indicating copy to clipboard operation
buddy copied to clipboard

chore: Update vitest to v3

Open rickard-von-essen opened this issue 7 months ago • 4 comments

rickard-von-essen avatar May 24 '25 18:05 rickard-von-essen

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 44.76%. Comparing base (38489a5) to head (95bdc2e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #116      +/-   ##
==========================================
+ Coverage   44.39%   44.76%   +0.36%     
==========================================
  Files         108      106       -2     
  Lines       12669     9326    -3343     
  Branches      593      556      -37     
==========================================
- Hits         5625     4175    -1450     
+ Misses       7036     5145    -1891     
+ Partials        8        6       -2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar May 24 '25 18:05 codecov[bot]

@rickard-von-essen it seems the code coverage for web worker breaks with vitest v3. Can you please have a look?

You can see that this PR changes the code coverage numbers, whereby it shouldn't actually. What happens here is that the web worker is excluded from the total, thus increasing the ratio tested/untested.

raphaelcoeffic avatar May 29 '25 05:05 raphaelcoeffic

Didn't notice that. I'll have a look in few days.

rickard-von-essen avatar May 30 '25 09:05 rickard-von-essen

Failed to convert coverage for file:///Users/ext.rickard.von/src/edgetx-buddy/src/webworker/backend.worker.ts.
 TypeError: Cannot read properties of undefined (reading 'endCol')
    at range.sliceRange (file:///Users/ext.rickard.von/src/edgetx-buddy/node_modules/@vitest/coverage-v8/dist/provider.js:554:55)
    at CovSource.offsetToOriginalRelative (file:///Users/ext.rickard.von/src/edgetx-buddy/node_modules/@vitest/coverage-v8/dist/provider.js:1985:20)
    at V8ToIstanbul._maybeRemapStartColEndCol (file:///Users/ext.rickard.von/src/edgetx-buddy/node_modules/@vitest/coverage-v8/dist/provider.js:2394:93)
    at file:///Users/ext.rickard.von/src/edgetx-buddy/node_modules/@vitest/coverage-v8/dist/provider.js:2303:61
    at Array.forEach (<anonymous>)
    at file:///Users/ext.rickard.von/src/edgetx-buddy/node_modules/@vitest/coverage-v8/dist/provider.js:2301:21
    at Array.forEach (<anonymous>)
    at V8ToIstanbul.applyCoverage (file:///Users/ext.rickard.von/src/edgetx-buddy/node_modules/@vitest/coverage-v8/dist/provider.js:2300:13)
    at file:///Users/ext.rickard.von/src/edgetx-buddy/node_modules/@vitest/coverage-v8/dist/provider.js:2762:16
    at async Promise.all (index 9)

rickard-von-essen avatar May 31 '25 17:05 rickard-von-essen