edge-react-gui icon indicating copy to clipboard operation
edge-react-gui copied to clipboard

Published 20 hours ago • verified publisher icon EdgeApp

Create account infinite loading fix

Open Jon-edge opened this issue 2 years ago • 1 comments

Somehow, the changes from Action->navigation (5d7ae1a172d0cc5e6508c0fb017f58c2006775cd) caused a failure to properly navigate to the wallet list scene after login, upon creating a new account.

Move the transition to the wallet list scene to the end of account initialization.

PR Dependencies

none

PR Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • [x] Tested on iOS device
  • [ ] Tested on Android device
  • [ ] Tested on small-screen device (iPod Touch)
  • [ ] Tested on large-screen device (tablet)
  • To see the specific tasks where the Asana app for GitHub is being used, see below:
    • https://app.asana.com/0/0/1202731925884272

Jon-edge avatar Aug 09 '22 01:08 Jon-edge

Can you describe how this fixes the issue in the case of the create account flow? What was happening when the infinite spinner occurred and what does this change to fix that condition?

paullinator avatar Aug 09 '22 05:08 paullinator

This change is no longer needed after https://github.com/EdgeApp/edge-react-gui/pull/3575 and when tested working, xipu/cheesy-navigation

Jon-edge avatar Aug 12 '22 17:08 Jon-edge