edge-react-gui
edge-react-gui copied to clipboard
Use /bin/sh instead of bash if possible in scripts
The below scripts in repo use bash either by #!/bin/bash
or #!/usr/bin/env bash
, consider changing it to #!/bin/sh
and thus avoid the bash dependency, also see checkbashisms
tool to look for bash specific operations in scripts (as they should work in other shells as well)
https://github.com/EdgeApp/edge-react-gui/blob/57c780136923c286c5340f1f5e777b58b0bd3581/postinstall.sh#L1
https://github.com/EdgeApp/edge-react-gui/blob/d46ded2286de0aae49cd949b4b6ac33c9f285ecc/ios/edge.xcodeproj/project.pbxproj#L337
Edge is only tested and guaranteed to work on macOS which always has bash. What platform are you trying to build the app with that doesn’t have bash?
I am currently writing Containerfile to compile thie android app based on alpine linux that doesn't have bash by default (can be installed) thus migrating to /bin/sh
enable the compilation of android app without installing additional bash dependency (only change in postinstall.sh
is relevant)