gumbel icon indicating copy to clipboard operation
gumbel copied to clipboard

Minimizing KL (not maximizing)

Open sherjilozair opened this issue 8 years ago • 1 comments

Thanks for uploading this. However, there is an error.

In the loss computation, you have elbo = data_dim * bce(x, x_hat) - KL.

It should be elbo = data_dim * bce(x, x_hat) + KL instead.

sherjilozair avatar Nov 20 '16 02:11 sherjilozair

just noticed this too, can submit a pr if wanted

adammenges avatar Sep 19 '17 20:09 adammenges