Max Kasperowski

Results 47 comments of Max Kasperowski

In ```BinaryIndexedTree``` in the ```rank``` method an ```IndexOutOfBoundsError``` now occurs with [this](http://www.irisa.fr/cosi/HOMEPAGE/Derrien/ISTIC/SCC_graph.json) example graph. Other tests are still passing.

I'll get on that when I'm back from holiday

I'm not sure what could be causing this issue. Do you have an example graph that reproduces this problem that we could use to look into this?

shapeCoords was only added for ELK 0.10.0 https://github.com/eclipse-elk/elk/pull/1071. It should work with the current 0.10.0 release

I would need to look into it, but of the top of my head I think it shouldn't be an issue to just also transfer the properties from the graph...

I think it's something we should try and fix though for 0.10.1 if it's a desired use case.

@skieffer thanks for looking into it. I'll be back in the office next week and will try to clean up the issues then

This is indeed a bug, minimally reproduced in this [example](https://rtsys.informatik.uni-kiel.de/elklive/elkgraph.html?compressedContent=IYGw5g9gTglgLgCwLYC4AESpygUxwKHwDsIATHNIgRmLIqICZbzKBmNAb3zR7VEliJUGLLgK9KdSjQkkWjfAF98OUmHpU0AWgB8lBmhVqN2vUVb4gA). The problem seems to be in the position and size calculation of the graph after layout.

It should also be fixed in elkjs 0.10.0. If it's not I'll have to look into whether there is a separate issue or whether something went wrong during transpilation. Do...

There is definitely something wrong somewhere, I'm investigating this and will keep you updated