nativescript-admob icon indicating copy to clipboard operation
nativescript-admob copied to clipboard

Sending a view property will place ad in that view

Open JillevdW opened this issue 6 years ago • 2 comments

This will place the advertisement in the view you send. Before, that view would always get overwritten by the view of the rootViewController. Now, it simply checks if the view is present, and if it isn't it will take the key window.

JillevdW avatar Aug 23 '18 12:08 JillevdW

Has this ever been merged? I am getting "AdMob error: Error: This value is not a native object" error when pointing view property to an image object. My goal is to show the image when no banner is ad shown.

Is the view property supported for banner ads? Can anyone share a working sample code?

Thank you!

MustafaCa avatar Aug 03 '19 12:08 MustafaCa

This has not been merged unfortunately because the changeset is polluted with many files that probably were committed by accident (check the "files changed") tab. I can only accept PRs that focus on fixing the issue as this is impossible to code review and merge.

EddyVerbruggen avatar Aug 06 '19 07:08 EddyVerbruggen