cordova-plugin-googleplus icon indicating copy to clipboard operation
cordova-plugin-googleplus copied to clipboard

Published 20 hours ago • verified publisher icon EddyVerbruggen

feat(sdk): support latest SDK versions for Android and iOS

Open booleanbetrayal opened this issue 2 years ago • 7 comments

This PR updates SDKs for Android and iOS to the latest versions and provides override support as suggested by @marioshtika in the event that a non-conflicting / minor patch version can be targeted as needed. Several aspects of the iOS and Android code needed to be updated.

This unbreaks integration with other plugins such as @havesource/cordova-plugin-push.

NOTE: The current inception of this PR breaks support for trySilentLogin as it was not a required feature to support our app. I'm open to upstream contributions if it's something the community still needs, but it may be worth just shelving if the plugin is otherwise broken for the majority of users due to conflicting SDK dependencies across projects.

booleanbetrayal avatar Sep 13 '22 22:09 booleanbetrayal

👍👍👍

justinschier avatar Sep 13 '22 23:09 justinschier

I used this in a new cordova project (android only). I got it working by pulling the fork, merging the pr branch locally, and pointing cordova to my local dir. Somehow it actually just worked perfectly. Webstorm fussed about the bad git mappings, but I just ignored the warnings. Hope this helps someone else who is drowning in cordova auth hell like I was the past 2 weeks.

thewebkid avatar Oct 09 '22 02:10 thewebkid

I think this pull request should be reviewed before merging it. By removing the deprecated/unnecessary functionalities, this plugin will no longer be backward compatible. I am already using the isAvailable and the trySilentLogin functions on my projects, so if I update it to this pr it will break my app. Maybe those functionalities can be removed on a major release of the plugin example on version 9.0.0 Just food for thought :)

marioshtika avatar Oct 10 '22 07:10 marioshtika

@marioshtika - I welcome any backfill for isAvailable and trySilentLogin, if people still require them, but they weren't necessary for us while the rest of these changes were. Wanted to get this PR up for posterity.

booleanbetrayal avatar Oct 11 '22 13:10 booleanbetrayal

It's probably worth updating this PR as GoogleSignIn pod has now been updated to 7.0.0, it probably has breaking changes

jpike88 avatar Dec 19 '22 11:12 jpike88

This repository is not being updated in years, so any merge would be a success.

Let's hope @EddyVerbruggen hears our request for help 🤞

marioshtika avatar Dec 19 '22 14:12 marioshtika

Any update on this @EddyVerbruggen ?

boengli avatar Feb 28 '23 10:02 boengli