EBPhotoPages icon indicating copy to clipboard operation
EBPhotoPages copied to clipboard

Prevent dots from displaying at all?

Open TheGeekPharaoh opened this issue 10 years ago • 7 comments

I'm have a use case where we are not allowing any actions at all on photos being displayed in EBPhotoPages. We've disabled them all via the EBPhotoPagesDataSource instance, but the "..." button is still being displayed in the toolbar, even though there are no associated actions. Is there any way to prevent the dots from being shown in the first place? A button with no actions associated with it provides a poor user experience.

TheGeekPharaoh avatar Jul 09 '14 15:07 TheGeekPharaoh

Yes, make sure your data source always returns NO for this method

- (BOOL)photoPagesController:(EBPhotoPagesController *)photoPagesController shouldAllowMiscActionsForPhotoAtIndex:(NSInteger)index;

If it still appears this may be a bug.

EddyBorja avatar Jul 09 '14 17:07 EddyBorja

I am returning NO, but I still see the button at the bottom of the screen. It doesn't do anything, but it's still there.

TheGeekPharaoh avatar Jul 09 '14 17:07 TheGeekPharaoh

And you're using the latest version of PhotoPages? This feature was added later.

On Wednesday, July 9, 2014, sdnakhla [email protected] wrote:

I am returning NO, but I still see the button at the bottom of the screen. It doesn't do anything, but it's still there.

— Reply to this email directly or view it on GitHub https://github.com/EddyBorja/EBPhotoPages/issues/8#issuecomment-48508270 .

EddyBorja avatar Jul 09 '14 17:07 EddyBorja

I'm using 0.9.1 via CocoaPods.  Is there a more recent version I should upgrade to?

On Wednesday, July 9, 2014 1:41 PM, Eddy Borja [email protected] wrote:

And you're using the latest version of PhotoPages? This feature was added later.

On Wednesday, July 9, 2014, sdnakhla [email protected] wrote:

I am returning NO, but I still see the button at the bottom of the screen. It doesn't do anything, but it's still there.

— Reply to this email directly or view it on GitHub https://github.com/EddyBorja/EBPhotoPages/issues/8#issuecomment-48508270 .

— Reply to this email directly or view it on GitHub.

TheGeekPharaoh avatar Jul 10 '14 13:07 TheGeekPharaoh

Yea there have been 10 commits since 0.9.1, the podspec has to be updated. I wish there was an auto-updating script for podspecs.

EddyBorja avatar Jul 11 '14 16:07 EddyBorja

Will you be updating the pod spec any time soon? Or will I have to build it manually to get the latest commits?

TheGeekPharaoh avatar Aug 04 '14 15:08 TheGeekPharaoh

I'm buried in work right now so I don't have time, but maybe I'll get to it in a few days.

On Mon, Aug 4, 2014 at 11:38 AM, sdnakhla [email protected] wrote:

Will you be updating the pod spec any time soon? Or will I have to build it manually to get the latest commits?

— Reply to this email directly or view it on GitHub https://github.com/EddyBorja/EBPhotoPages/issues/8#issuecomment-51076661 .

EddyBorja avatar Aug 04 '14 15:08 EddyBorja