[REVIEW] UmairJibran

[UmairJibran]

Portfolio link

https://umairjibran.com

Changes in Progress

https://polite-river-0640ed603-30.westeurope.azurestaticapps.net/

NOTE If you can only review one (please do the one with changes in progress)

[github-actions[bot]]

It's great having you contribute to this project

Welcome to the community :nerd_face:

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord Server and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

[ErrolFernandes]

Everything seems okay!but it would be good if you change the font of Ur name as it is not readable friendly.

[UmairJibran]

Thanks @ErrolFernandes I would do that ASAP!!

[Panquesito7]

Awesome portfolio! I really loved it ❤️ great work!

I just recommend making this part

look like

Thanks for sharing your awesome portfolio with the amazing community! 😄

[UmairJibran]

hey @Panquesito7 thanks for the suggestion, however, I would like to take another input from you as well. my initial thoughts were having professional social/links and general socialising links separately.

do you think it was a good idea? I mean given that you noticed it, I suppose I should stick them up together.

[Panquesito7]

That sounds like a good idea! But I would like to make it look both like in the screenshot I showed. 🙂

[UmairJibran]

Thanks a lot @Panquesito7 I have added this in the TODO I will do them ASAP, hopefully by the end of the week, fingerscrossed

[EmmaDawsonDev]

Nice design and a lot of it works really well. I tested with keyboard navigation and it's easy to move around your site. However, there are a few accessibility issues which you can pick up if you run a lighthouse test.

On the projects page I would suggest making all the cards the same size so it looks more uniform. Also, I'm unsure why you've hidden things away behind dropdowns on the education page. I'd suggest having them visible all the time as it avoids too many clicks which many people are adverse to.

[UmairJibran]

Thank you @emmalearnscode that is a very great idea, I will make them always expand on the education page, I am looking for some ideas because even though the current cards deliver the required info, I want to make them more pleasing.

[KendallDoesCoding]

@UmairJibran Please share the source code of the portfolio too, Eddie likes checking the source code in his live stream reviews and mostly giving feedback on that.

[eddiejaoude]

Please share the github repo link

[eddiejaoude]

No GitHub link, going to close - please submit a new issue if you have a GitHub repo link