support icon indicating copy to clipboard operation
support copied to clipboard

Published 20 hours ago • verified publisher icon EddieHubCommunity

[REVIEW] kalashsharma.me

Open k99sharma opened this issue 3 years ago • 10 comments

Portfolio link

https://www.kalashsharma.me/

k99sharma avatar Jul 28 '21 16:07 k99sharma

It's great having you contribute to this project

Welcome to the community :nerd_face:

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord Server and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

github-actions[bot] avatar Jul 28 '21 16:07 github-actions[bot]

I'll let the designers comment on aesthetics. Here's something I spotted, though.

When you mouse-over (1 and 2) your recent projects the background resizes. image

Look at the size difference image

mikeysan avatar Aug 01 '21 00:08 mikeysan

Yes, actually I was going to fix this issue. But this portfolio is temporary, and I will make a new single-page portfolio with a blog feature. Until then I will open this as an issue and maybe someone can fix this for me. Thanks for your comment!

k99sharma avatar Aug 01 '21 19:08 k99sharma

I really liked your about me section, I got a good impression of you as a person from it. A few ideas:

  • there are some colour contrast and hierarchy issues with your main content on the first page. The blue on black is too dark and although it’s bigger the white text stands out more so the eye is drawn there more than anywhere else.
  • Add more projects so we can see your skills

EmmaDawsonDev avatar Dec 24 '21 19:12 EmmaDawsonDev

Please share the github repo link

eddiejaoude avatar Aug 15 '22 16:08 eddiejaoude

I was just about to ask if this should be closed when I noticed your last comment, @eddiejaoude was two days ago 😄 I suppose a link to the repo would be good as a final step before closing.

mikeysan avatar Aug 17 '22 12:08 mikeysan

I was going to give them a bit more time to share a repo link - if there isn't one we can close

eddiejaoude avatar Aug 17 '22 12:08 eddiejaoude

https://www.kalashsharma.me/ is not available @k99sharma is it the repository https://github.com/k99sharma/React-Portfolio and new link https://www.kalashsharma.com ?

schmelto avatar Aug 17 '22 12:08 schmelto

Hey @eddiejaoude I just saw your email. I think I missed the previous email somehow and was not able to reply back soon.

Portfolio link: https://www.kalashsharma.com

k99sharma avatar Aug 17 '22 13:08 k99sharma

@schmelto you are right. I re-designed the portfolio in react and got a new domain name. Actually I got the last one using GitHub student pack and it got expired after 1 year.

k99sharma avatar Aug 17 '22 13:08 k99sharma

No GitHub link, going to close - please submit a new issue if you have a GitHub repo link

eddiejaoude avatar Aug 22 '22 15:08 eddiejaoude