good-first-issue-finder icon indicating copy to clipboard operation
good-first-issue-finder copied to clipboard

Published 20 hours ago • verified publisher icon EddieHubCommunity

[Enhancment] Remove system button theme

Open RaheemAmer opened this issue 2 years ago • 2 comments

Description

Suggestion

  1. I don't see a value for that button since there are already two separate buttons for light and dark themes, so a silly suggestion would be to implement the system theme by default with no need for a button once the user enters the website

  2. Also, the two buttons are really close and similar to each other which is a little bit annoying to figure out and maybe a bad practice for the Ui

Articles

  1. https://medium.com/hypersphere-codes/detecting-system-theme-in-javascript-css-react-f6b961916d48
  2. https://davidwalsh.name/detect-dark-mode-preference-with-javascript
  3. https://dev.to/bibekkakati/system-color-theme-check-in-javascript-1la9

Screenshots

image

RaheemAmer avatar Oct 01 '22 01:10 RaheemAmer

Can you assign this issue to me? I can solve it!

xx-abhijeet-xx avatar Oct 01 '22 09:10 xx-abhijeet-xx

The system setting does exactly what the linked article suggest. It picks and matches that mediaQuery and sets the theme based on that [1]. Computers are providing the setting to switch the dark theme based on day time for example, which means the theme of our page changes dynamically based on that setting.

In case we default to this and remove the button, there wouldn't be an option of going back to the system-wide setting.

Because of that, I think we shouldn't delete that option currently.

Cahllagerfeld avatar Oct 01 '22 13:10 Cahllagerfeld

If we are fine with the system button then we should close this issue

sambhavgupta0705 avatar Dec 09 '22 19:12 sambhavgupta0705