good-first-issue-finder icon indicating copy to clipboard operation
good-first-issue-finder copied to clipboard

Prevent Flash when Darkmode is selected

Open Cahllagerfeld opened this issue 3 years ago • 4 comments

Description

Currently, when using Darkmode and the page gets called, there's an initial flash where the page is still white. This should be prevented

Screenshots

No response

Additional information

No response

Cahllagerfeld avatar Aug 18 '22 14:08 Cahllagerfeld

I think that will happen because it take time to download page .To solve this you can use cookie from the server side.

kumarsanu2002 avatar Aug 19 '22 05:08 kumarsanu2002

Hi there , Please assign it me

sanyamgandhak avatar Oct 01 '22 14:10 sanyamgandhak

Hi there, Checked it and also compared it to the other website dark mode . I think working is fine . But as there no single button for toggling the dark mode we are getting the feel of the initial flash . What do you think ?

sanyamgandhak avatar Oct 01 '22 17:10 sanyamgandhak

My take on the issue is, that the Page is rendered with light-mode initially. I'm not sure, as I didn't spend time on this issue yet, but my solution would be to store the state in the cookie, and then do the Theme-Rendering on the server

Cahllagerfeld avatar Oct 01 '22 17:10 Cahllagerfeld