gh-action-community icon indicating copy to clipboard operation
gh-action-community copied to clipboard

Is this a bit too spammy? (It's great having you contribute to this project)

Open stemount opened this issue 4 years ago • 6 comments

Opening a new issue as a seasoned EddieHub contributor/mod/whatever... it seems quite counterproductive to always respond with a thanks - especially as I imagine this creates more notifications but I could be totally wrong here!

Maybe it can fire off once for a new member who has contributed to an issue or even created their first issue then never fire off again?

stemount avatar Jan 26 '21 01:01 stemount

It's great having you contribute to this project

Welcome to the community :nerd_face: If any questions please ask

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

github-actions[bot] avatar Jan 26 '21 01:01 github-actions[bot]

This actually wouldn't be too difficult to implement within the action.

naomi-lgbt avatar Jan 26 '21 01:01 naomi-lgbt

This is a good idea. Here is an example https://github.com/JJ/issue-greeting-action/blob/master/src/main.ts#L56

async function isFirstIssue(
  client: github.GitHub,
  owner: string,
  repo: string,
  sender: string,
  curIssueNumber: number
): Promise<boolean> {
  const {status, data: issues} = await client.issues.listForRepo({
    owner: owner,
    repo: repo,
    creator: sender,
    state: 'all'
  });

  if (status !== 200) {
    throw new Error(`Received unexpected API status code ${status}`);
  }

  if (issues.length === 0) {
    return true;
  }

  for (const issue of issues) {
    if (issue.number < curIssueNumber && !issue.pull_request) {
      return false;
    }
  }

  return true;
}

eddiejaoude avatar Feb 02 '21 22:02 eddiejaoude

Would be great if it was first time or you could exclude usernames like dependabot f.ex.

indiehjaerta avatar Oct 27 '22 21:10 indiehjaerta

We are using another Action to do the greeting now, so hopefully it is better

eddiejaoude avatar Oct 28 '22 10:10 eddiejaoude

Yup! I don't want to receive notifications for issues I create myself

LoneDev6 avatar Sep 29 '23 10:09 LoneDev6