EventCalendar icon indicating copy to clipboard operation
EventCalendar copied to clipboard

Make it clear that the `package.json` and `package-lock.json` Should not be committed

Open NS007-dev opened this issue 3 years ago • 8 comments

I have seen in some pull requests that the package.json is being committed as well, maybe it should be in the .gitignore files or should made clear to not add the package files. Thank you.

NS007-dev avatar Nov 05 '21 20:11 NS007-dev

We should make this clear not to commit, these should not be ignored otherwise people cannot install in the dependencies

eddiejaoude avatar Nov 05 '21 22:11 eddiejaoude

yes otherwise their might be different version of packages installed for different people.

mohan-murali avatar Nov 06 '21 05:11 mohan-murali

We should make this clear not to commit, these should not be ignored otherwise people cannot install in the dependencies

Yes I agree

NS007-dev avatar Nov 06 '21 08:11 NS007-dev

I will change the issue name. Thank you

NS007-dev avatar Nov 06 '21 08:11 NS007-dev

thank you 👍

eddiejaoude avatar Nov 06 '21 08:11 eddiejaoude

Is this to be added in the readme?

gptkrsh avatar Nov 20 '21 15:11 gptkrsh

Yes, I think that is where it should be said @krishguptadev

NS007-dev avatar Nov 20 '21 17:11 NS007-dev

I think we should wait for the contributing.md file and add it there instead. Thanks 😊👍

gptkrsh avatar Nov 21 '21 03:11 gptkrsh