BioDrop icon indicating copy to clipboard operation
BioDrop copied to clipboard

[FEATURE] Adding a Docker Compose file

Open RishiKumarRay opened this issue 3 years ago • 10 comments

Description

Adding a Docker Compose file

Screenshots

No response

Additional information

No response

RishiKumarRay avatar Jan 11 '22 10:01 RishiKumarRay

It's great having you contribute to this project

Welcome to the community :nerd_face:

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

github-actions[bot] avatar Jan 11 '22 10:01 github-actions[bot]

Can you assign me this and I can work on this

RishiKumarRay avatar Jan 11 '22 14:01 RishiKumarRay

Can you explain why this would be beneficial to the project? I don't know anything about docker - what does a docker compose file do? Why should we have one in this project?

EmmaDawsonDev avatar Jan 11 '22 15:01 EmmaDawsonDev

This project already has Dockerfile , now if you want to run this in a container first you have to build a image then run which is a time consuming. Now if we add a docker compose here , it will run this application in a single command . Also if your priority is not running this in Dockerized environment do let me know , I am happy to close this issue.

RishiKumarRay avatar Jan 11 '22 15:01 RishiKumarRay

I have no idea, but there may be other maintainers who think this is a good idea. Leave the issue open and collect some more opinions on it from others :)

EmmaDawsonDev avatar Jan 11 '22 15:01 EmmaDawsonDev

I use Docker Composer when I have multiple containers, I have not used it for when there is just 1 file.

Adding the file won't hurt though and will help when we adda DB etc

eddiejaoude avatar May 17 '22 08:05 eddiejaoude

hi @eddiejaoude can you assign this ticket to me?

rohitdasu avatar Aug 09 '22 16:08 rohitdasu

@rohitdasu sure, just to let you know, we have started a docker composer file in the new version of LinkFree here https://github.com/EddieHubCommunity/LinkFree/blob/nextjs/docker-compose.yml

Let me know if yo still want the ticket

eddiejaoude avatar Aug 10 '22 07:08 eddiejaoude

Hi @eddiejaoude i've checked the docker-compose.yml file. I think it's not completed, if we docker-compose up it won't run the Next.js image file and also i've seen that there is a mongodb service issues. As you know in docker database data will be deleted after we stop the container. so i can prevent it by adding volumes. If you think this will help then let me know. Thanks 😊 🙏

rohitdasu avatar Aug 10 '22 14:08 rohitdasu

let me know if you need me on this one

FrancescoXX avatar Oct 01 '22 14:10 FrancescoXX

thanks @FrancescoXX 👍

I think this is taken care of now, in the latest version. A new issue can be raised with specific information if it is still required

eddiejaoude avatar Nov 05 '22 22:11 eddiejaoude