BioDrop icon indicating copy to clipboard operation
BioDrop copied to clipboard

[BUG] Automated tests for Premium users

Open eddiejaoude opened this issue 1 year ago • 17 comments

Description

We should at least test that pages with premium features and premium pages load without any error

Screenshots

No response

Do you want to work on this issue?

None

Additional information

No response

eddiejaoude avatar Sep 14 '23 13:09 eddiejaoude

To reduce notifications, issues are locked until they are https://github.com/EddieHubCommunity/BioDrop/labels/%F0%9F%8F%81%20status%3A%20ready%20for%20dev and to be assigned. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

github-actions[bot] avatar Sep 14 '23 13:09 github-actions[bot]

The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

github-actions[bot] avatar Sep 24 '23 11:09 github-actions[bot]

Hello, I am new here and would like to take up this issue as my first contribution. Can this be assigned to me? Can someone please explain the issue with more details as well?

Abhishek-90 avatar Sep 30 '23 10:09 Abhishek-90

Hi @Abhishek-90 welcome! Thank you for your enthusiasm but we ask that all new contributors start out with issues which range from 1 Point to 3 Points.

SaraJaoude avatar Sep 30 '23 20:09 SaraJaoude

using playwright?

theunhackable avatar Oct 29 '23 13:10 theunhackable

yes we use playwright, you can find existing test files in the tests directory

ℹ️ eddiejaoude has some opened assigned issues: 🔧View assigned issues

eddiejaoude avatar Oct 31 '23 11:10 eddiejaoude

I would like to work on this. I will start by taking a look in the tests directory.

erikkristoferanderson avatar Nov 21 '23 11:11 erikkristoferanderson

Awesome Erik! I have assigned it to you.

This issue is quite vague, I think we should keep it small enough to add value, then new issues can be created afterwards. After you have looked at the test directory let me know what you think or if you have any questions

eddiejaoude avatar Nov 21 '23 12:11 eddiejaoude

Unassigning as no activity

ℹ️ eddiejaoude has some opened assigned issues: 🔧View assigned issues

eddiejaoude avatar Dec 30 '23 14:12 eddiejaoude

I would like to take it up, but can you describe more as to what is the expectations out of it?

ℹ️ Abhishek-90 has some opened assigned issues: 🔧View assigned issues

Abhishek-90 avatar Jan 05 '24 14:01 Abhishek-90

I will take that if abhishek has opened assigned issues.

theunhackable avatar Jan 05 '24 15:01 theunhackable

I will take that if abhishek has opened assigned issues.

@theunhackable I have assigned this to you - please take into consideration this comment.

SaraJaoude avatar Jan 06 '24 09:01 SaraJaoude

Given the length of time since this issue has been assigned and as no PR has been created, @theunhackable I am unassigning this from you to give someone else a chance to work on it.

SaraJaoude avatar Feb 04 '24 10:02 SaraJaoude

I would like to take it up.

Abhishek-90 avatar Feb 06 '24 06:02 Abhishek-90

I would like to take it up.

@Abhishek-90 I will assign this to you

SaraJaoude avatar Feb 06 '24 09:02 SaraJaoude

So far as per my analysis, there 3 premium features present.

  1. Hide Navbar: We can add a test to check if when the account is a premium user, the navbar is hidden.
  2. Hide Footer: We can add a test to check if when the account is a premium user, the footer is hidden.
  3. Custom Domain: We can add a test to check if when the account is a premium user, the domain(url) is of users choice.

To implement these, one thing that is required is to check if the account is premium, in that case, we can simply check if the for the page, the navbar and footer are hidden or no. For 3rd one, I will need some assistance.

Hence, we can create 3 different issues, to add 3 different test cases.

Let me know you views and suggestions.

Abhishek-90 avatar Feb 07 '24 16:02 Abhishek-90

Hello, I went through the features of premium page again and referred existing tests for different pages. There are some basic automated tests that also we can add:

  1. Go to url:/account/manage/premium, there should be a switch with Label Hide Navbar on your Profile.
  2. Go to url:/account/manage/premium, there should be a switch with Label Hide Footer on your Profile.
  3. Go to url:/account/manage/premium, there should be a SAVE button which is disabled by default.

If there seems like valid test, let me know how should I proceed further, Should I add all 3 tests in 1 go, or shall I created 3 different issues for each cases. Each Issue can be a 2/3 pointer, whereas a single issue could be 8 pointer.

Abhishek-90 avatar Feb 23 '24 05:02 Abhishek-90