BioDrop icon indicating copy to clipboard operation
BioDrop copied to clipboard

[BUG] Warning message on the forms

Open Pradumnasaraf opened this issue 1 year ago • 6 comments

Description

As the message says, please delete the username.json file and the username folder. However, if someone provides a testimonial to that user, it will again create a folder with that person's username, which may cause confusion for them.

Screenshots

Screenshot 2023-06-29 at 11 45 50 PM

Additional information

A potential solution could be supporting testimonials through the UI.

Pradumnasaraf avatar Jun 29 '23 18:06 Pradumnasaraf

To reduce notifications, issues are locked until they are https://github.com/EddieHubCommunity/LinkFree/labels/%F0%9F%8F%81%20status%3A%20ready%20for%20dev and to be assigned. You can learn more in our contributing guide https://github.com/EddieHubCommunity/LinkFree/blob/main/CONTRIBUTING.md

github-actions[bot] avatar Jun 29 '23 18:06 github-actions[bot]

Good point - I've added the discussion label and unlocked so that people can share their suggested solutions.

SaraJaoude avatar Jun 30 '23 12:06 SaraJaoude

I like @Pradumnasaraf suggestion of supporting testimonials via the UI. In the meantime, perhaps there is a way to hide this notification by checking in the path if it leads to a profile.json or to testimonials.

amandamartin-dev avatar Jul 07 '23 12:07 amandamartin-dev

Yep moving testimonials to forms is a longer term solution but we need to think of a way to also solve this for people who add testimonials via the issue which will create a json file 🤔

eddiejaoude avatar Jul 10 '23 09:07 eddiejaoude

Yep moving testimonials to forms is a longer term solution but we need to think of a way to also solve this for people who add testimonials via the issue which will create a json file 🤔

Would a simple conditional statement work to hide/show the notification?

Like if profile.json exists, show notification, else hide

amandamartin-dev avatar Jul 11 '23 12:07 amandamartin-dev

At the moment I think we check for the [username].json file. But the testimonial is in [username]/testimonial/[testimonial-username].json file - so if they remove the folder, and someone adds a testimonial afterwards via the issue template, the folder and file will reappear and the receiver will have to keep deleting this folder 🤔

eddiejaoude avatar Jul 16 '23 19:07 eddiejaoude