BioDrop icon indicating copy to clipboard operation
BioDrop copied to clipboard

Published 20 hours ago • verified publisher icon EddieHubCommunity

Added filter to show free and paid events

Open shyam0705 opened this issue 2 years ago • 3 comments

Fixes Issue

closes #2901

Changes proposed

1)Added filter to show all free and paid events. 2)Modified documentation to suggest adding the startingFrom field in events

Check List (Check all the applicable boxes)

  • [x] My code follows the code style of this project.
  • [x] My change requires changes to the documentation.
  • [x] I have updated the documentation accordingly.
  • [ ] All new and existing tests passed.
  • [x] This PR does not contain plagiarized content.
  • [x] The title of my pull request is a short description of the requested changes.

Screenshots

https://user-images.githubusercontent.com/72148710/218325819-59e11c2d-0787-44fc-aa68-3a760e1608de.mp4

Note to reviewers

shyam0705 avatar Feb 12 '23 17:02 shyam0705

Hi! Thank you for working on this. I have a few questions (I have not pulled the code to test yet)

What does the mobile experience look like with the added filters? What happens in the case of cost not provided? How will the filters handle this scenario?

Also, one of the build tests is failing if you are able to take a look at the error

amandamartin-dev avatar Feb 12 '23 19:02 amandamartin-dev

Hi! Thank you for working on this. I have a few questions (I have not pulled the code to test yet)

What does the mobile experience look like with the added filters? What happens in the case of cost not provided? How will the filters handle this scenario?

Also, one of the build tests is failing if you are able to take a look at the error

  • I am attaching a video of the mobile view.
  • In case of cost is not provided for any of the events, then both free and paid events will be zero.
  • I don't know why one test case is failing. Can you re-run it

https://user-images.githubusercontent.com/72148710/218520205-3847d381-ee46-4d12-b80e-c3a232f446d7.mp4

shyam0705 avatar Feb 13 '23 16:02 shyam0705

I could be wrong let me know if I am :)

Hi, the code you are commenting on is part of the playwright tests and not changes included in this PR. To decrease confusion for folks, make sure to only comment on parts of the application and code relevant to this PR. If you believe there are better ways to implement some of the tests you may propose them in a new issue, or start a conversation in ideas in Discord.

amandamartin-dev avatar Apr 26 '23 18:04 amandamartin-dev

Hello @shyam0705 thank you so much for your patience on our reviews of this issue. It got pushed down in priority a bit, but would love to move forward and continue working.

You may notice that the branch is now out of date and their are conflicts in a few files. Please pull in main to your branch and see if you are able to fix the merge conflicts.

If you are uncomfortable figuring out how to do that or no longer have time to work on this issue please comment and another maintainer will be able to help collaborate on getting this ready for review again.

Thank you!!!

amandamartin-dev avatar Apr 26 '23 18:04 amandamartin-dev

Sorry it is my fault I didn't look at this sooner, so I have resolved the conflicts

eddiejaoude avatar May 23 '23 05:05 eddiejaoude

I will merge into a temporary branch and fix the error and failing test etc

eddiejaoude avatar May 23 '23 07:05 eddiejaoude