BioDrop
BioDrop copied to clipboard
Added location to all events (In-person && Remote)
I have made a working prototype of the location parameter in events. Also I have updated the docs too. Please have a look at the screenshot and let me know if you like it or not -->

(The Docs containing the location parameter. Now all the required flags are true, because if the InPerson flag is set as true, then you need to set the location parameters. Otherwise, means if isVirtual is set as true && isInPerson is false, then by fault the location will be remote)

(It is the layout of the events page containing the location) Please suggest, if I should make any changes in the layout or not!
Fixes Issue #4132
Changes proposed
Check List (Check all the applicable boxes)
- [x] My code follows the code style of this project.
- [x] My change requires changes to the documentation.
- [x] I have updated the documentation accordingly.
- [ ] All new and existing tests passed.
- [x] This PR does not contain plagiarized content.
- [x] The title of my pull request is a short description of the requested changes.
Screenshots
Note to reviewers
Hi @Pradumnasaraf, can you please review this PR?
Hey @ManishBisht777 and @Pradumnasaraf, updated the code, so that even if we do not give any location
, it will not give any error.
Also in the docs, it is NOT mandatory.
Hey @Pradumnasaraf, requesting you to review this PR.
Hey @Pradumnasaraf, requesting you to review this PR.
Hey, thanks for the PR. I don't look at frontend. Some will soon review it. Also, you don't need to tag any maintainers, it creates an extra notification. Thank you for your patience.
Hey @eddiejaoude , this Pr is ready for review. Merging this would unblock the other map related issues.
Thank you! Sorry for my slow review, we have a lot of PRs coming in. This is on my list of things to do