BioDrop icon indicating copy to clipboard operation
BioDrop copied to clipboard

[FEATURE] Add location to in-person events

Open ChinmayMhatre opened this issue 2 years ago • 22 comments

Description

Maybe we could add a location to the in person events?

Screenshot 2023-01-27 at 11 49 42 PM

Screenshots

No response

Additional information

No response

ChinmayMhatre avatar Jan 27 '23 18:01 ChinmayMhatre

It's great having you contribute to this project

Welcome to the community :nerd_face:

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

github-actions[bot] avatar Jan 27 '23 18:01 github-actions[bot]

Great point. Later with the data, we can also add to the live map to see which conferences are happening nearby.

Pradumnasaraf avatar Jan 27 '23 19:01 Pradumnasaraf

Can I try to do this one please @ChinmayMhatre and @Pradumnasaraf?

ShuvamChatterjee28 avatar Jan 28 '23 14:01 ShuvamChatterjee28

Hey ! Can I try to work on this issue ? @Pradumnasaraf

Vishrut19 avatar Jan 28 '23 14:01 Vishrut19

I think the data we need to capture is...

"location": {
   "road": "",
   "city": "",
   "state": "",
   "country": ""
}

Please add to the docs also

eddiejaoude avatar Jan 29 '23 06:01 eddiejaoude

I think the data we need to capture is...

"location": {
   "road": "",
   "city": "",
   "state": "",
   "country": ""
}

Please add to the docs also

okay @eddiejaoude I got some idea about it. Where can I discuss about it with you ?

Vishrut19 avatar Jan 29 '23 07:01 Vishrut19

Hey @eddiejaoude, can you kindly assign me?

ShuvamChatterjee28 avatar Jan 29 '23 07:01 ShuvamChatterjee28

Hello @eddiejaoude, I'll be so happy to work on this issue. Kindly let me work on this.

Mutai-Gilbert avatar Jan 29 '23 18:01 Mutai-Gilbert

Can I try to do this one please @ChinmayMhatre and @Pradumnasaraf?

Hey @ShuvamChatterjee28 I can't assign it to you. But you can go ahead with this. If you want any help let us know. Thank you!

ChinmayMhatre avatar Jan 30 '23 09:01 ChinmayMhatre

Hey, @ShuvamChatterjee28 you can go ahead and others, please look for other issues.

Thank you!

Pradumnasaraf avatar Jan 30 '23 09:01 Pradumnasaraf

Hey @Pradumnasaraf! @ShuvamChatterjee28 is already assigned and working on an issue i.e. issue number #4223. You can have a look at it.

Vishrut19 avatar Jan 30 '23 09:01 Vishrut19

For #4223, the PR is created. Thanks. Working on this issue now.

ShuvamChatterjee28 avatar Jan 30 '23 10:01 ShuvamChatterjee28

Idk! what kind of system is this that you want to contribute to Open Source? Some folks are assigned more than one issue which is fine but if you are asking for an issue again and again but no one is assigning you. That's so cool! @Pradumnasaraf

Vishrut19 avatar Jan 30 '23 10:01 Vishrut19

Hey, @ShuvamChatterjee28,

@ShuvamChatterjee28 commented on the issue 1st, this is why they are been assigned. Also, I didn't know that they are already assigned to an issue, and people can work on 1-2 issues together.

You can look for other open issues. I know you are an enthusiast and want to contribute. Hope you understand.

Pradumnasaraf avatar Jan 30 '23 10:01 Pradumnasaraf

Cool no problem @Pradumnasaraf and also I have found an issue. Where can I raise it ?

Vishrut19 avatar Jan 30 '23 10:01 Vishrut19

Cool no problem @Pradumnasaraf and also I have found an issue. Where can I raise it ?

Here - https://github.com/EddieHubCommunity/LinkFree/issues/new/choose

Pradumnasaraf avatar Jan 30 '23 10:01 Pradumnasaraf

Hey @Pradumnasaraf and @eddiejaoude, I have made a working prototype of the location parameter in events. Also I have updated the docs too. Please have a look at the screenshot and let me know if you like it or not --> Screenshot 2023-02-01 at 9 52 21 PM (The Docs containing the location parameter. Now all the required flags are false, because I have set the code like, if isVirtual is set as true && isInPerson is false, then by fault the location will be remote)

Screenshot 2023-02-01 at 10 03 59 PM (It is the layout of the events page containing the location)

Please suggest, if I should make any changes in the layout or not!

ShuvamChatterjee28 avatar Feb 01 '23 16:02 ShuvamChatterjee28

Hey @ShuvamChatterjee28 , I think it would be best if you created a PR with your solution. The changes could be discussed over on the PR. Thanks

ChinmayMhatre avatar Feb 01 '23 17:02 ChinmayMhatre

Got it @ChinmayMhatre, will create a PR. Thanks.

ShuvamChatterjee28 avatar Feb 01 '23 18:02 ShuvamChatterjee28

Yes, you can raise a draft PR!

Pradumnasaraf avatar Feb 01 '23 19:02 Pradumnasaraf

Hey @ShuvamChatterjee28 just had a doubt what if event is in hybrid mode??? The logic will still show remote.

saaagarsingh avatar Feb 07 '23 03:02 saaagarsingh

Nope, it is updated now.

ShuvamChatterjee28 avatar Feb 07 '23 04:02 ShuvamChatterjee28

@eddiejaoude I would like to work on this

ashutosh887 avatar Mar 13 '23 15:03 ashutosh887

@ashutosh887 please read the history of the issue timeline, you will see it is already assigned and a pull request has already been created.

Please have a look at the issue list and select an issue that

  • is not already assigned (unless more than 2 weeks with no activity and we can reassign it)
  • has no existing pul request
  • also the issue has the label status: ready for dev

eddiejaoude avatar Mar 13 '23 23:03 eddiejaoude

Thanks @eddiejaoude I'll keep this in mind

ashutosh887 avatar Mar 14 '23 03:03 ashutosh887

PR has been merged

eddiejaoude avatar Mar 29 '23 18:03 eddiejaoude