BioDrop icon indicating copy to clipboard operation
BioDrop copied to clipboard

`OG` add twitter card and og image

Open harshraj8843 opened this issue 2 years ago • 2 comments

Changes proposed

  • Better OG images

Why

While sharing LinkFree links on Discord or Twitter, I noticed that the LinkFree OG can be improved.

I have some prior experience with creating dynamic OG images. So, I created one for LinkFree 🤗

How

Repo: https://github.com/codinasion/LinkFree-OG

OG images are created by Github actions and updates every 6/12 hours (not decided yet!)

The OG images are provided through an API 👉🏻 https://linkfreeog.codinasion.org

There are two separate APIs, one for LinkFree and the other for User Profile

LinkFree: https://linkfreeog.codinasion.org Profile: https://linkfreeog.codinasion.org/<GITHUB_USERNAME>

Showcase

LinkFree Profile Another Profile

What difference it makes (on Discord)

harshraj8843 avatar Jan 16 '23 22:01 harshraj8843

Note There are some profile OGs missing because LinkFree API return Internal Server Error

Reference 👉🏻 https://linkfree.eddiehub.io/api/users/ibrahimq21

harshraj8843 avatar Jan 16 '23 22:01 harshraj8843

Note There are some profile OGs missing because LinkFree API return Internal Server Error Reference 👉🏻 linkfree.eddiehub.io/api/users/ibrahimq21

Hey @Panquesito7

any fix for this 🤔

harshraj8843 avatar Jan 17 '23 06:01 harshraj8843

Update

Now able to handle all profiles 🚀 🎉

Link: https://api.codinasion.org/linkfree-og/ibrahimq21

Fixed

How

If LinkFree API response is 500 then GET profile Json directly from Github

harshraj8843 avatar Jan 18 '23 09:01 harshraj8843

Note Some profiles Json have incorrect data. That may be the reason for LinkFree API 500 response(s) 🤔

url vs Url vs URL

https://github.com/EddieHubCommunity/LinkFree/blob/10d7d70bccff54cf782dd656393dc18d4b9d8941/data/Drabzit.json#L13-L20

Broken Links

https://github.com/EddieHubCommunity/LinkFree/blob/10d7d70bccff54cf782dd656393dc18d4b9d8941/data/Drabzit.json#L15

harshraj8843 avatar Jan 18 '23 09:01 harshraj8843

Hey @eddiejaoude @Pradumnasaraf

Could you please review this PR 👀

Thank you in advance for your time and consideration 🤗

harshraj8843 avatar Jan 23 '23 06:01 harshraj8843

Thank you for your contribution. It is better to raise an issue first so these can be discussed without you doing work first.

It looks good, but 3rd party services like this go up and down, and therefore have a negative effect on our app.

Currently I am not keen on introducing this dependency. Maybe we can do something similar on a smaller scale as part of the application itself?

eddiejaoude avatar Jan 24 '23 12:01 eddiejaoude

Sure, thanks

harshraj8843 avatar Jan 24 '23 14:01 harshraj8843