BioDrop icon indicating copy to clipboard operation
BioDrop copied to clipboard

[FEATURE] Fixing Navbar on Mobile to Stay in Place instead of Pushing Content Down [good first issue]

Open Aadarsh805 opened this issue 2 years ago • 5 comments

Description

Currently, whenever the navbar is opened on a mobile-sized screen, it pushes down the main page content down It'd be better to have it fixed and open above the content mobile-sized

Screenshots

Currently

screen-capture (13)

After changes proposed

screen-capture (1fsd0)

Additional information

If it's approved, it's a good first issue for beginners to work on

Aadarsh805 avatar Jan 15 '23 20:01 Aadarsh805

It's great having you contribute to this project

Welcome to the community :nerd_face:

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

github-actions[bot] avatar Jan 15 '23 20:01 github-actions[bot]

Hi @Aadarsh805 I would like to work on this.

Note: Do you want it to be transparent as well, so that the content underneath can be seen?

imtiazpy avatar Jan 16 '23 07:01 imtiazpy

Hi @Aadarsh805 I would like to work on this.

Note: Do you want it to be transparent as well, so that the content underneath can be seen?

Let a maintainer have a look at this, they'll assign you as well I think making it transparent will disturb the color theme

Aadarsh805 avatar Jan 16 '23 09:01 Aadarsh805

I understand your perspective, but recreating the design in the same way as before may result in the navigation bar covering up the content. This would make the content invisible again. @Aadarsh805

imtiazpy avatar Jan 17 '23 06:01 imtiazpy

Hi @Aadarsh805 I would like to work on this.

Note: Do you want it to be transparent as well, so that the content underneath can be seen?

I think if someone is opening the menu then their focus will be on the menu itself, making the navbar transparent will make the background text and the nav links text blend a bit causing it difficult to read for users as well.

ManishBisht777 avatar Jan 17 '23 17:01 ManishBisht777

How about making this action a bit more smooth by adding transition?

rohinish404 avatar Jan 17 '23 19:01 rohinish404

Yes make sure to add the transition, whoever that is going to work on this

Aadarsh805 avatar Jan 17 '23 20:01 Aadarsh805

@Pradumnasaraf can you please review the issue and the suggestions which one to go for, also do assign imtiazpy if the issue is valid

Aadarsh805 avatar Jan 17 '23 20:01 Aadarsh805

I understand your perspective, but recreating the design in the same way as before may result in the navigation bar covering up the content. This would make the content invisible again. @Aadarsh805

The content being visible is not the issue that's being addressed, it's the shifting in the layout that should not happen like that for no reason

Aadarsh805 avatar Jan 17 '23 22:01 Aadarsh805

I got it @Aadarsh805

Waiting for a maintainer to have a look into the issue and assign me.

imtiazpy avatar Jan 18 '23 14:01 imtiazpy

@Pradumnasaraf can you please review the issue and the suggestions which one to go for, also do assign imtiazpy if the issue is valid

Hey, I am not sure about this UI addition. Tagging @eddiejaoude

Pradumnasaraf avatar Jan 19 '23 17:01 Pradumnasaraf

Hey, @Aadarsh805 I added the PR a while back to make the navbar functional. In my opinion, you should add a transition to it making it look smoother, but the content pushing makes the UI cooler. What do you think? @eddiejaoude

k99sharma avatar Jan 22 '23 19:01 k99sharma

Great discussion everyone, lots of great ideas 👍

I think we should do small steps so we can see and test the improvements. So I think the first and most simple step that adds value is making it transition first, then we can take it from there

eddiejaoude avatar Jan 22 '23 19:01 eddiejaoude

@imtiazpy you can start with this, If you're free

Aadarsh805 avatar Jan 22 '23 19:01 Aadarsh805

This does not appear to be causing any challenges at the moment, so I will close this for now.

SaraJaoude avatar Feb 04 '23 12:02 SaraJaoude