BioDrop icon indicating copy to clipboard operation
BioDrop copied to clipboard

Feature icons to be clickable

Open HarshDeep61034 opened this issue 2 years ago • 11 comments

Added Link to icons on the Main Page of the LinkFree Website.

Fixes Issue

closes #3151

Changes proposed

Check List (Check all the applicable boxes)

  • [ ] My code follows the code style of this project.
  • [ ] My change requires changes to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] All new and existing tests passed.
  • [ ] This PR does not contain plagiarized content.
  • [ ] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

HarshDeep61034 avatar Jan 15 '23 13:01 HarshDeep61034

@Aadarsh805 sure Thanks! , I want to ask How did you see the preview of the website before getting the code merged?

HarshDeep61034 avatar Jan 15 '23 13:01 HarshDeep61034

@Aadarsh805 sure Thanks! , I want to ask How did you see the preview of the website before getting the code merged?

Github offers a feature to checkout individual PRs so you can preview them on your local machine before they get merged, that is most probably how :)

orbitalmartian8 avatar Jan 15 '23 13:01 orbitalmartian8

@Aadarsh805 sure Thanks! , I want to ask How did you see the preview of the website before getting the code merged?

Through GitPod, it makes code

@Aadarsh805 sure Thanks! , I want to ask How did you see the preview of the website before getting the code merged?

There are multiple option, you can either use GitPod or the GitHub codespaces I prefer GitHub's you can create codespaces for individual prs to run them, this is where you do it from image

well for smaller changes like this, I just copy/paste the changes into my vscode, and run from there

Aadarsh805 avatar Jan 15 '23 13:01 Aadarsh805

Alright thanks for letting me know. @Aadarsh805

HarshDeep61034 avatar Jan 15 '23 15:01 HarshDeep61034

@Aadarsh805 why the check failed is there any error?

HarshDeep61034 avatar Jan 15 '23 17:01 HarshDeep61034

@Aadarsh805 why the check failed is there any error?

I have no idea, might be because of some accessibility issue Let's ask on discord

Aadarsh805 avatar Jan 15 '23 17:01 Aadarsh805

That's a really good point, for screen readers especially

Aadarsh805 avatar Jan 15 '23 18:01 Aadarsh805

@Aadarsh805 why the check failed is there any error?

Hey @HarshDeep61034 try adding aria-label="Go to feature page" on the link

Aadarsh805 avatar Jan 15 '23 18:01 Aadarsh805

@Aadarsh805 why the check failed is there any error?

Hey @HarshDeep61034 try adding aria-label="Go to feature page" on the link

Thanks it worked!!

HarshDeep61034 avatar Jan 16 '23 06:01 HarshDeep61034

@Aadarsh805 why the check failed is there any error?

Hey @HarshDeep61034 try adding aria-label="Go to feature page" on the link

Thanks it worked!!

Cool

Aadarsh805 avatar Jan 16 '23 09:01 Aadarsh805

I wonder if this change is really needed. Given that the heading on the card is clickable adding a link to the icon as well creates two tab stops for each card which lead to the same place. For anyone navigating with keyboard or assistive technology this adds unnecessary noise. Ideally there would only be one link, either as it is now or making the whole card into a link instead.

Seems like we still have 2 links?

eddiejaoude avatar Jan 21 '23 09:01 eddiejaoude

I wonder if this change is really needed. Given that the heading on the card is clickable adding a link to the icon as well creates two tab stops for each card which lead to the same place. For anyone navigating with keyboard or assistive technology this adds unnecessary noise. Ideally there would only be one link, either as it is now or making the whole card into a link instead.

Seems like we still have 2 links?

@HarshDeep61034 you're working on it right?

Aadarsh805 avatar Jan 21 '23 11:01 Aadarsh805

I wonder if this change is really needed. Given that the heading on the card is clickable adding a link to the icon as well creates two tab stops for each card which lead to the same place. For anyone navigating with keyboard or assistive technology this adds unnecessary noise. Ideally there would only be one link, either as it is now or making the whole card into a link instead.

Seems like we still have 2 links?

@HarshDeep61034 you're working on it right?

It's not clear to me what are the requested changes? Can you elaborate

HarshDeep61034 avatar Jan 21 '23 11:01 HarshDeep61034

I wonder if this change is really needed. Given that the heading on the card is clickable adding a link to the icon as well creates two tab stops for each card which lead to the same place. For anyone navigating with keyboard or assistive technology this adds unnecessary noise. Ideally there would only be one link, either as it is now or making the whole card into a link instead.

Seems like we still have 2 links?

@HarshDeep61034 you're working on it right?

It's not clear to me what are the requested changes? Can you elaborate

Make the whole card one link, remove links from the icon and h2 also fix the aria-label to Go to ${feature.name} page

Aadarsh805 avatar Jan 21 '23 11:01 Aadarsh805