BioDrop icon indicating copy to clipboard operation
BioDrop copied to clipboard

Published 20 hours ago • verified publisher icon EddieHubCommunity

[FEATURE] Use Intl API instead of `js-abbreviation-number`

Open gptkrsh opened this issue 2 years ago • 3 comments

Description

JavaScript has a Intl api (internationalization API) which does meet our use case requirements, no need for another dependency

Screenshots

No response

Additional information

No response

gptkrsh avatar Jan 15 '23 12:01 gptkrsh

It's great having you contribute to this project

Welcome to the community :nerd_face:

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

github-actions[bot] avatar Jan 15 '23 12:01 github-actions[bot]

I would like to work on this.

Rishabh-Singh-Codes avatar Jan 15 '23 15:01 Rishabh-Singh-Codes

Hey @Rishabh-Singh-Codes I have already made a PR for this and am working on it :) Thanks for showing interest though

gptkrsh avatar Jan 15 '23 15:01 gptkrsh

Hey @krshkun , I think there was an issue while linked the PR. Since the PR is merged could you close the issue?

ChinmayMhatre avatar Jan 23 '23 08:01 ChinmayMhatre

Oh unsure why it didn't close

gptkrsh avatar Jan 23 '23 12:01 gptkrsh