[Make the icons clickable]

[harshcodesdev]

trafficstars

Description

while visiting the LinkFree website I immediately clicked on icons but found out the Icons are not clickable but the text below is, so I request that we could make those icons clickable because it comes by Natural Human-instinct to click them.

Screenshots

Additional information

No response

[github-actions[bot]]

It's great having you contribute to this project

Welcome to the community :nerd_face:

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

[Aadarsh805]

How about making the whole card clickable along with the heading and the icons We can also have a hover box shadow on the whole card

[harshcodesdev]

that would be much better!

[eddiejaoude]

Good idea 👍 . This PR just got merged for the headings of that section, but the icon would be good - not sure if the whole card would work, someone would have to try

[harshcodesdev]

Alright Thanks @eddiejaoude

[eddiejaoude]

Keep it simple for now, let's keep moving forward often with little steps not slowly with big leaps - do the icon first and the card can come in another issue/pull request as it is probably more work

[harshcodesdev]

can someone guide me on this issue? , I can't understand how to approach this one. @Aadarsh805 @ChinmayMhatre

[Aadarsh805]

can someone guide me on this issue? , I can't understand how to approach this one. @Aadarsh805 @ChinmayMhatre

yes sure, you see here in the code

the h3(the title of the cards: quickstart, links and all other) has a Link inside it, making it a link that will take us to thr href defined now we want the same thing for the icon above it, as we made h3 a link right there, we can do the same for the icon above this is in the path pages/index.js line around 410

I hope you got it, If you need further help, feel free to ask

[harshcodesdev]

Thanks @Aadarsh805 😃

[EmmaDawsonDev]

Keep it simple for now, let's keep moving forward often with little steps not slowly with big leaps - do the icon first and the card can come in another issue/pull request as it is probably more work

Sorry Eddie but I’m gonna veto this change to only do the icon first. It’s not good for accessibility to have two links side by side that go to the same place, it creates a lot of extra tab stops and noise.

[eddiejaoude]

Thanks Emma for the great feedback 👍

Could you clarify, are you suggesting not to make any changes at all or only to do part of it?

[EmmaDawsonDev]

Thanks Emma for the great feedback 👍

Could you clarify, are you suggesting not to make any changes at all or only to do part of it?

Either keep it as the heading of the card that is the only link, or just go ahead and make the entire card a link

[harshcodesdev]

The entire card would be better what do you think @eddiejaoude @Aadarsh805

[harshcodesdev]

Thanks for the Amazing feedback @EmmaDawsonDev

[Aadarsh805]

this is how it looks like when the whole card is the link

screen-capture (12).webm

[harshcodesdev]

This is more of a Subjective choice, Personally, I feel This one Looks better.

[eddiejaoude]

Can you share a screenshot please, webp does work on safari

[Aadarsh805]

Can you share a screenshot please, webp does work on safari

Here's a gif of the same video

might look a little blurry, it's because of the conversion

[eddiejaoude]

Is it possible to make the whole card clickable? if having 2 is not a good idea

[Sriparno08]

Hey @eddiejaoude, I have found a way to make the whole card clickable, just like in the video/gif. So, can I work on this?

[Aadarsh805]

Hey @eddiejaoude, I have found a way to make the whole card clickable, just like in the video/gif. So, can I work on this?

there is already a pr on this #3485

[Sriparno08]

Alright, @Aadarsh805 👍

[harshcodesdev]

@Sriparno08 you can work buddy I'm really busy with my exams.

[Sriparno08]

Thanks bro 👍

Hey @Aadarsh805, can I go ahead and make a PR as @HarshDeep61034 is busy right now?

[Aadarsh805]

Thanks bro +1

Hey @Aadarsh805, can I go ahead and make a PR as @HarshDeep61034 is busy right now?

sure

[alokVerma749]

we can create a card component that can accept Heading, Paragraph, and Link so that it can be used anywhere we want