BioDrop icon indicating copy to clipboard operation
BioDrop copied to clipboard

Added filter to show free and paid events

Open shyam0705 opened this issue 2 years ago • 6 comments

Fixes Issue

Closes #2901

Changes proposed

1)Added filter to show all free and paid events. 2)Modified documentation to suggest adding the startingFrom field in events

Check List (Check all the applicable boxes)

  • [x] My code follows the code style of this project.
  • [x] My change requires changes to the documentation.
  • [x] I have updated the documentation accordingly.
  • [x] All new and existing tests passed.
  • [x] This PR does not contain plagiarized content.
  • [x] The title of my pull request is a short description of the requested changes.

Screenshots

UI:- UI Modified events for testing purpose:- e1 e2

Note to reviewers

shyam0705 avatar Jan 10 '23 15:01 shyam0705

Looks good, I think the field should be more descriptive, something like ...

price: {
   startingFrom: 0
}

Thanks @eddiejaoude, I will make changes soon.

shyam0705 avatar Jan 12 '23 02:01 shyam0705

Thanks for making the changes 👍 During testing, I got this error on the user profile page...

Screenshot 2023-01-12 at 10 35 15

eddiejaoude avatar Jan 12 '23 10:01 eddiejaoude

Also please update main into this branch to reduce any future conflicts

eddiejaoude avatar Jan 12 '23 10:01 eddiejaoude

Thanks for making the changes 👍 During testing, I got this error on the user profile page...

Screenshot 2023-01-12 at 10 35 15

Can you check now? I'm sorry; I completely missed adding free and paid categories in the user event tab.

shyam0705 avatar Jan 12 '23 11:01 shyam0705

Can you check now? I'm sorry; I completely missed adding free and paid categories in the user event tab.

no problem, these things happen to everyone

These changes are going to have challenges with another PR https://github.com/EddieHubCommunity/LinkFree/pull/3125

I think the extra filter is a good idea, but not sure how to display it so it doesn't take up too much space on the page 🤔

eddiejaoude avatar Jan 17 '23 10:01 eddiejaoude

Can you check now? I'm sorry; I completely missed adding free and paid categories in the user event tab.

no problem, these things happen to everyone

These changes are going to have challenges with another PR #3125

I think the extra filter is a good idea, but not sure how to display it, so it doesn't take up too much space on the page 🤔

I guess we can modify @Aadarsh805 design to include the following and previous icons. We can have a design like pagination.

shyam0705 avatar Jan 17 '23 14:01 shyam0705

@eddiejaoude and @shyam0705 I noticed this has stalled, can we pick it back up? I saw the comment about the filters but we could break that part out into a separate issue. wdyt?

amandamartin-dev avatar Jan 28 '23 12:01 amandamartin-dev

@eddiejaoude and @shyam0705, I noticed this has stalled, can we pick it back up? I saw the comment about the filters but we could break that part out into a separate issue. wdyt?

@amandamartin-dev sorry, I was busy due to some personal reasons last week. will pick this back. I am thinking about creating a separate issue to display filters as we add more filters in future.

shyam0705 avatar Feb 05 '23 06:02 shyam0705