BioDrop icon indicating copy to clipboard operation
BioDrop copied to clipboard

chore(deps): update deps

Open gptkrsh opened this issue 2 years ago • 9 comments

Update dependencies, why because:

  1. Most of these include bug fixes
  2. Some of these are performance improvements (next v13.1)
  3. Nothing breaks, but if don't update dependencies regularly then everything will soon.

gptkrsh avatar Jan 10 '23 15:01 gptkrsh

I think this PR might not be needed anymore. I did a bunch of updates in my testing PR which got merged today.

dan-mba avatar Jan 11 '23 12:01 dan-mba

@dan-mba I'm kind of still trying to merge the changes because it isn't the easier. I'm marking this PR as draft for right now

gptkrsh avatar Jan 11 '23 15:01 gptkrsh

@dan-mba I'm kind of still trying to merge the changes because it isn't the easier. I'm marking this PR as draft for right now

I understand, but wanted to make sure this didn't get accidentally merged by someone trying to keep up with the flood of PRs

dan-mba avatar Jan 11 '23 15:01 dan-mba

Thanks for updating the dependencies 👍 it is good to do these often 💯

eddiejaoude avatar Jan 11 '23 22:01 eddiejaoude

I do not know what just happened. I synced the forks using github ui

gptkrsh avatar Jan 12 '23 04:01 gptkrsh

@dan-mba, now this PR only updates the other two dependencies that haven't been updated 👍

Edit: Looks like I can only request review from one of you at a time, so tagging should do: @eddiejaoude

gptkrsh avatar Jan 12 '23 04:01 gptkrsh

If there are changes in the package file, we need to include changes to the lock file as well in this PR

eddiejaoude avatar Jan 12 '23 10:01 eddiejaoude

Yes @eddiejaoude, actually I'm waiting for this PR to approved (ready to merge or something) and then I can package-lock.json so it's merged in quick succession and that there aren't any conflicts

gptkrsh avatar Jan 12 '23 10:01 gptkrsh

Conflict, we proabaly need to merge this soon after it is recreated. Let's try tomorrow

Btw don't resolve the conflicts, just regenerated the file

eddiejaoude avatar Jan 13 '23 22:01 eddiejaoude