BioDrop
BioDrop copied to clipboard
[FEATURE] If profile only has links then do not show dropdown or tab
Description
Currently, a dropdown is rendered on mobile regardless of if it is needed or not. This issue is to handle not rendering a dropdown for profiles that contain only links and only render a dropdown on 2 or more items.
Screenshots
Current mobile view with links only, dropdown has been clicked in this image. Dropdown is not needed here
Additional information
No response
It's great having you contribute to this project
Welcome to the community :nerd_face:If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.
@amandamartin-dev how does this look? do you have any other suggestions on how it should be
Hey @Aadarsh805 Thank you for the screenshot I think that will work nicely. For now, I know you have already taken on another issue that you are assigned to so I will leave this one open for someone else to try first. If no one picks it up, feel free to ask once you have completed the other issue you are working. Appreciate your contributions!
Hey @Aadarsh805 Thank you for the screenshot I think that will work nicely. For now, I know you have already taken on another issue that you are assigned to so I will leave this one open for someone else to try first. If no one picks it up, feel free to ask once you have completed the other issue you are working. Appreciate your contributions!
I'm already done with that issue though, but yeah let's wait if someone else wanna grab this one, it's a good issue for beginners
i would like to work on this issue if its possible
@Aadarsh805 thank you so much for sharing the good first issues and so sorry I didn't realize you were already dne with events. So fast!!
@amirzgh I will assign you now, thanks for contributing
@amirzgh feel free to ask for help if you get stuck somewhere 😇
I think removing the dropdown/tab is best for mobile if only links are used - it will keep the UI cleaner
Yes, that makes sense esp since tabs are used elsewhere too
Hello @amirzgh, are you working on this? If you are not working on this, then I can work.
@SaraJaoude @amandamartin-dev i would like to work this issue, if its still open.
@arun-kushwaha04 I have assigned this to you
@SaraJaoude sorry for delayed response, got busy on some other task. I have created PR regarding this issue.
Could I be assigned to this!
@KaveriRai I have assigned this to you
@KaveriRai I have assigned this to you
Thank you