BioDrop icon indicating copy to clipboard operation
BioDrop copied to clipboard

[FEATURE] If profile only has links then do not show dropdown or tab

Open amandamartin-dev opened this issue 2 years ago • 13 comments

Description

Currently, a dropdown is rendered on mobile regardless of if it is needed or not. This issue is to handle not rendering a dropdown for profiles that contain only links and only render a dropdown on 2 or more items.

Screenshots

Current mobile view with links only, dropdown has been clicked in this image. Dropdown is not needed here Screenshot Amanda profile on android with dropdown clicked showing it has one item only

Additional information

No response

amandamartin-dev avatar Jan 10 '23 13:01 amandamartin-dev

It's great having you contribute to this project

Welcome to the community :nerd_face:

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

github-actions[bot] avatar Jan 10 '23 13:01 github-actions[bot]

@amandamartin-dev how does this look? do you have any other suggestions on how it should be image

Aadarsh805 avatar Jan 10 '23 16:01 Aadarsh805

Hey @Aadarsh805 Thank you for the screenshot I think that will work nicely. For now, I know you have already taken on another issue that you are assigned to so I will leave this one open for someone else to try first. If no one picks it up, feel free to ask once you have completed the other issue you are working. Appreciate your contributions!

amandamartin-dev avatar Jan 10 '23 17:01 amandamartin-dev

Hey @Aadarsh805 Thank you for the screenshot I think that will work nicely. For now, I know you have already taken on another issue that you are assigned to so I will leave this one open for someone else to try first. If no one picks it up, feel free to ask once you have completed the other issue you are working. Appreciate your contributions!

I'm already done with that issue though, but yeah let's wait if someone else wanna grab this one, it's a good issue for beginners

Aadarsh805 avatar Jan 10 '23 18:01 Aadarsh805

i would like to work on this issue if its possible

amirzgh avatar Jan 10 '23 18:01 amirzgh

@Aadarsh805 thank you so much for sharing the good first issues and so sorry I didn't realize you were already dne with events. So fast!!

@amirzgh I will assign you now, thanks for contributing

amandamartin-dev avatar Jan 10 '23 18:01 amandamartin-dev

@amirzgh feel free to ask for help if you get stuck somewhere 😇

Aadarsh805 avatar Jan 10 '23 19:01 Aadarsh805

I think removing the dropdown/tab is best for mobile if only links are used - it will keep the UI cleaner

eddiejaoude avatar Jan 11 '23 21:01 eddiejaoude

Yes, that makes sense esp since tabs are used elsewhere too

amandamartin-dev avatar Jan 11 '23 22:01 amandamartin-dev

Hello @amirzgh, are you working on this? If you are not working on this, then I can work.

ShuvamChatterjee28 avatar Jan 28 '23 06:01 ShuvamChatterjee28

@SaraJaoude @amandamartin-dev i would like to work this issue, if its still open.

arun-kushwaha04 avatar Feb 05 '23 14:02 arun-kushwaha04

@arun-kushwaha04 I have assigned this to you

SaraJaoude avatar Feb 06 '23 03:02 SaraJaoude

@SaraJaoude sorry for delayed response, got busy on some other task. I have created PR regarding this issue.

arun-kushwaha04 avatar Feb 14 '23 14:02 arun-kushwaha04

Could I be assigned to this!

KaveriRai avatar Mar 24 '23 19:03 KaveriRai

@KaveriRai I have assigned this to you

SaraJaoude avatar Mar 25 '23 01:03 SaraJaoude

@KaveriRai I have assigned this to you

Thank you

KaveriRai avatar Mar 27 '23 18:03 KaveriRai