BioDrop icon indicating copy to clipboard operation
BioDrop copied to clipboard

[FEATURE] To have a dark theme in LinkFree

Open everydaycodings opened this issue 2 years ago • 38 comments
trafficstars

Description

If there is a dark theme in the LinkFree. Then it will Be Great.

Screenshots

No response

Additional information

No response

everydaycodings avatar Jan 09 '23 16:01 everydaycodings

It's great having you contribute to this project

Welcome to the community :nerd_face:

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

github-actions[bot] avatar Jan 09 '23 16:01 github-actions[bot]

literally I was thinking the same thing

immortalAbdul01 avatar Jan 09 '23 17:01 immortalAbdul01

i was also thinking the same

harshcodesdev avatar Jan 09 '23 17:01 harshcodesdev

This will be a great addition. Using Global variables this can be achieved. Another way would be to use local storage on the user's browser and check the theme before the app is mounted.

I would love to work on this.

thevinitgupta avatar Jan 10 '23 04:01 thevinitgupta

Same here haha!

shubhxg avatar Jan 10 '23 06:01 shubhxg

I was thinking the same thing Actually

s4shantanu avatar Jan 11 '23 03:01 s4shantanu

I was thinking the same thing or even change of themes

KimberlyPangilinan avatar Jan 11 '23 18:01 KimberlyPangilinan

Themes would be good 👍

eddiejaoude avatar Jan 12 '23 00:01 eddiejaoude

I think there could be an option of like changing themes based on your browser settings maybe, or 2 light themes and 2 dark themes. That would be awesome!! 🎉

shubhxg avatar Jan 12 '23 06:01 shubhxg

  1. Background customize ( #3317 ) maybe we can provide some given sets of background images to use instead of the user uploading them.

  2. Dark theme ( #2957 )

  3. Different ways to show links/cards/milestones etc ( #2214 )

These are 3 Customization ideas for the profiles.

@eddiejaoude Any Suggesstions?

ManishBisht777 avatar Jan 13 '23 09:01 ManishBisht777

  1. Background customize ( [FEATURE] Background image/ Wallpaper with theme toggle #3317 ) maybe we can provide some given sets of background images to use instead of the user uploading them.
  2. Dark theme ( [FEATURE] To have a dark theme in LinkFree #2957 )
  3. Different ways to show links/cards/milestones etc ( Feature: Socials section design #2214 )

These are 3 Customization ideas for the profiles.

@eddiejaoude Any Suggesstions?

Yes the user providing the background image can cause some displaying issues like the text will not be visible if the user uses a dark background

Aadarsh805 avatar Jan 13 '23 14:01 Aadarsh805

Its better to approach things "simple" first.

Going for the "themes" option instead of "background image" is a better option in my opinion.

Two Basic suggestions are Dark and Light.

What do you think @eddiejaoude ? :)

Adding theme color ideas Screenshot 😄 Theme Ideas for LinkFree

shubhxg avatar Jan 13 '23 15:01 shubhxg

Its better to approach things "simple" first.

Going for the "themes" option instead of "background image" is a better option in my opinion.

Two Basic suggestions are Dark and Light.

What do you think @eddiejaoude ? :)

Adding theme color ideas Screenshot 😄 Theme Ideas for LinkFree

Or maybe we can add personalization with accent colors. Accent colors does not affect the display much

I can see here that we have orange as default. We can add some colors like violet and such.

Though it may affect the branding i guess

Screenshot_20230113_234646_com.android.chrome.jpg

If we want to preserve the branding as orange, i think let's stick with the light theme and dark theme with the orange as its accent color

KimberlyPangilinan avatar Jan 13 '23 15:01 KimberlyPangilinan

Great Idea @KimberlyPangilinan, Well, let's see what @eddiejaoude thinks about this. :D

shubhxg avatar Jan 13 '23 16:01 shubhxg

Thank you @shubhsharma19 , you also have wonderful insights

KimberlyPangilinan avatar Jan 13 '23 16:01 KimberlyPangilinan

Great collaboration everyone 💪

Yes keeping it simple is a great idea and we can keep improving little by little

eddiejaoude avatar Jan 14 '23 22:01 eddiejaoude

yup small steps do make remarkable changes!

harshcodesdev avatar Jan 15 '23 10:01 harshcodesdev

Well, Can I try to make a Dark mode? I am interested to work on this. I found this repo recently (in my stars 😂) and would like to contribute to it.

Siddhesh-Agarwal avatar Jan 17 '23 04:01 Siddhesh-Agarwal

Possible duplicate of #1838 ? Anyway, dark mode would be a fantastic addition. Was gonna suggest the same.

FrozenHearth avatar Jan 17 '23 17:01 FrozenHearth

on which track are we planning to go:

  1. Themes (modes): Dark/Light mode
  2. Themes (styles): a user adds a "style": "dark" in the data/<username>.json file, then we can apply that style to the user.

Siddhesh-Agarwal avatar Jan 17 '23 17:01 Siddhesh-Agarwal

on which track are we planning to go:

  1. Themes (modes): Dark/Light mode
  2. Themes (styles): a user adds a "style": "dark" in the data/<username>.json file, then we can apply that style to the user.

maybe the first one as toggling the dark mode to the whole site would be better than just the profile in my opinion

ManishBisht777 avatar Jan 17 '23 17:01 ManishBisht777

on which track are we planning to go:

1. Themes (modes): Dark/Light mode

2. Themes (styles): a user adds a `"style": "dark"` in the `data/<username>.json`  file, then we can apply that style to the user.

I think the first one should be implemented first and see what users actually feel about this.

Or just ask the users by putting a vote or something and let users decide what's better. (Light/Dark or Themes)

shubhxg avatar Jan 17 '23 18:01 shubhxg

I like the sound of dark mode

loftwah avatar Jan 18 '23 19:01 loftwah

Me too @loftwah :D

shubhxg avatar Jan 19 '23 14:01 shubhxg

I like when dark mode is triggered by a toggle, say in the top right somewhere. Appwrite does this really well.

image

Just click on this and it switches between dark/light

loftwah avatar Jan 20 '23 04:01 loftwah

Looks so good, I Love it!!!! @loftwah

shubhxg avatar Jan 20 '23 08:01 shubhxg

ezgif com-gif-maker

I tweaked a little bit with colors in chrome and it looks good!

k99sharma avatar Jan 22 '23 19:01 k99sharma

I would like to work on this starting with a global theme provider

@eddiejaoude we can add to a seperate branch right?

ManishBisht777 avatar Jan 23 '23 04:01 ManishBisht777

I would like to work on this starting with a global theme provider

@eddiejaoude we can add to a seperate branch right?

Hey @ManishBisht777 are you working on this? Could you explain what you mean by a global theme provider?

ChinmayMhatre avatar Jan 27 '23 06:01 ChinmayMhatre

I would like to work on this starting with a global theme provider @eddiejaoude we can add to a seperate branch right?

Hey @ManishBisht777 are you working on this? Could you explain what you mean by a global theme provider?

My bad I should have said a bit clearer, There is a package called next-themes it has a wrapper called ThemeProvidor it adds a dark theme support for our website

Not started yet but i am looking if it can be done easily without additional package or not

ManishBisht777 avatar Jan 27 '23 06:01 ManishBisht777