Found two user profiles whose GitHub profiles does not exist

[Aadarsh805]

Description

1. Skyhero-admin.json
2. aaquibdev.json

this error occurred due to this upstream image response failed for https://github.com/Skyhero-admin.png 404

Screenshots

this caused the random user section to generate only 4 user profiles, the 5th threw error

Additional information

There must be more accounts like this, it might be negligible for a large number of users (this happened on my local dev server, with smaller user list)

[github-actions[bot]]

It's great having you contribute to this project

Welcome to the community :nerd_face:

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

[eddiejaoude]

Thank you raising 👍

[MD-ARBAB-SAHID]

Description

1. Skyhero-admin.json
2. aaquibdev.json

this error occurred due to this upstream image response failed for https://github.com/Skyhero-admin.png 404

Screenshots

this caused the random user section to generate only 4 user profiles, the 5th threw error

Additional information

There must be more accounts like this, it might be negligible for a large number of users (this happened on my local dev server, with smaller user list)

@Aadarsh805 I also tried with dummy database with some users having GitHub profile and some not, but in that case it was using the fallbackSvg avatar instead of breaking from that point like as you mentioned because of unavailability 4th user 5th one was not displayed, I dont know if I'am getting it right or not 😅.

[Aadarsh805]

Description

1. Skyhero-admin.json
2. aaquibdev.json

this error occurred due to this upstream image response failed for https://github.com/Skyhero-admin.png 404

Screenshots

this caused the random user section to generate only 4 user profiles, the 5th threw error

Additional information

There must be more accounts like this, it might be negligible for a large number of users (this happened on my local dev server, with smaller user list)

@Aadarsh805 I also tried with dummy database with some users having GitHub profile and some not, but in that case it was using the fallbackSvg avatar instead of breaking from that point like as you mentioned because of unavailability 4th user 5th one was not displayed, I dont know if I'am getting it right or not sweat_smile.

The one I'm talking about here don't have a GitHub account, not just the profile picture If that's what you mean my having fallbackSvg in place of GitHub profile picture

[MD-ARBAB-SAHID]

@Aadarsh805 Even if the account is not there in github but if there is a json file in data dir in that case fallbackSvg will be used. It only displays on the console unable to find .png 404 but it does not decrease the number of profiles. Tried with some dummy profiles without Github account.

[Aadarsh805]

@Aadarsh805 Even if the account is not there in github but if there is a json file in data dir in that case fallbackSvg will be used. It only displays on the console unable to find .png 404 but it does not decrease the number of profiles. Tried with some dummy profiles without Github account.

Huh then that's weird, this is the error on my terminal This one's causing that, not the 404 one

[MD-ARBAB-SAHID]

@Aadarsh805 Even if the account is not there in github but if there is a json file in data dir in that case fallbackSvg will be used. It only displays on the console unable to find .png 404 but it does not decrease the number of profiles. Tried with some dummy profiles without Github account.

Huh then that's weird, this is the error on my terminal This one's causing that, not the 404 one

Then ig this error mainly occurs if profile is stored in mongodb database and the corresponding profile.json is not present in data directory irrespective of whether GitHub account exist or not. I created dummy user1,user2,user3,user4 which don't have a GitHub account but their data is stored in mongodb database but corresponding json files are not present in data dir. For user with username "HAT52" who has a Github account along with the "HAT52.json" stored in data dir. I deleted "HAT52.json" stored in data dir in that case it shows:

@eddiejaoude So ig error mainly occurs when data is present in the database and corresponding profile_data.json file is not present in data dir which leads to data inconsistency.

[eddiejaoude]

Great collaboration 👍

Yes if the user file is deleted ,they remain in the database - this is something we need to fix

I suggest if the file is not found, the user is removed from the database

[eddiejaoude]

These profiles do exist? 🤔

• Skyhero-admin.json https://github.com/EddieHubCommunity/LinkFree/blob/main/data/Skyhero-admin.json
• aaquibdev.json https://github.com/EddieHubCommunity/LinkFree/blob/main/data/aaquibdev.json

[psavan1655]

We can use a cron for that. Delete users from DB whose json file is not available. I would like to work on this cron job issue. If yes, let me know. i can create a issue in relation to this issue.

[Tusharjagi]

we can do one more like if user file is deleted then changes the UI { this user is not available }

something like that we can improve UI It's just an example

[SaraJaoude]

I will look into this.

[SaraJaoude]

@Skyhero-alt I believe that the account Skyhero-admin is your previous account. Can you please comment on this Issue so that we can address it and close it? You can either edit your LinkFree profile or close this if you decide you no longer require it.

[SaraJaoude]

With aaquibdev.json the GitHub username does not exist and none of the links work

[Skyhero-alt]

Yes it is my old account I think i will update the link Should I make a Pull request for it ?

[eddiejaoude]

@Skyhero-alt yes please 👍

[kumarsonsoff3]

With aaquibdev.json the GitHub username does not exist and none of the links work

From the commit history, I found that it's the previous account of @imaaquibali.

@imaaquibali, Since you have created a new LinkFree profile on your new username, could you please delete your old json file: https://github.com/EddieHubCommunity/LinkFree/blob/main/data/aaquibdev.json or we should address it?

[SaraJaoude]

Yes it is my old account I think i will update the link Should I make a Pull request for it ?

This has now been dealt with in: https://github.com/EddieHubCommunity/LinkFree/pull/6716

[SaraJaoude]

With aaquibdev.json the GitHub username does not exist and none of the links work

From the commit history, I found that it's the previous account of @imaaquibali.

@imaaquibali, Since you have created a new LinkFree profile on your new username, could you please delete your old json file: https://github.com/EddieHubCommunity/LinkFree/blob/main/data/aaquibdev.json or we should address it?

I will delete the file aaquibdev.json as:

• it has been two weeks and there has been no response from @imaaquibali
• the GitHub username does not exist
• the links mentioned in the file do not work

[aliaaquib]

@SaraJaoude Actualy I don't have access to my @imaaquibali account 😞. I lost my backup codes and forget to take backup of 2FA also.

If you know any other options to access my account please let me know.

I thought I already deleted my old profile btw thanks for deleting it 😊