BioDrop icon indicating copy to clipboard operation
BioDrop copied to clipboard

eddiejaoude profile shows fewer testimonials than those in the data

Open swiftugandan opened this issue 2 years ago • 2 comments

Description

I was comparing the number of testimonials in the data for @eddiejaoude and realised there is a discrepancy between what the profile shows (5 testimonials) and what is contained in the data (7 testimonials). Please have a look.

Screenshots

No response

Additional information

No response

swiftugandan avatar Jan 08 '23 16:01 swiftugandan

It's great having you contribute to this project

Welcome to the community :nerd_face:

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

github-actions[bot] avatar Jan 08 '23 16:01 github-actions[bot]

This is working correctly.

In order for a testimonial to be displayed, the name of the file in the testimonial directory must also be in the profile testimonials field. Only 5 of the 7 files meet this requirement.

Eddie's profile has 2 names in the testimonials section that don't have a matching file in the testimonials directory.

dan-mba avatar Jan 08 '23 16:01 dan-mba

Thank you both for collaborating 👍

Yep I am have not reviewed the other testimonials yet, so I have not included them on my profile. Currently these are the ones included https://github.com/EddieHubCommunity/LinkFree/blob/main/data/eddiejaoude.json#L20

Here are the docs to the testimonials section if you would like to learn more (or let us know if something doesn't make sense or is missing)

eddiejaoude avatar Jan 09 '23 08:01 eddiejaoude