BioDrop
BioDrop copied to clipboard
Main branch is not protected because of the GH Action needs to write
Description
The default branch main should be protected but for the Actions that need to write to main this is a problem
What are the solutions?
Screenshots
No response
Additional information
No response
It's great having you contribute to this project
Welcome to the community :nerd_face:If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.
Looks like it's not 100% possible yet, I guess? https://github.com/orgs/community/discussions/25305
Seems like an exception needs to be made in the branch protection rules. https://github.blog/changelog/2021-11-19-allow-bypassing-required-pull-requests/
Seems like an exception needs to be made in the branch protection rules. https://github.blog/changelog/2021-11-19-allow-bypassing-required-pull-requests/
Yeah, but I'm not sure the actions user can be added. And if it can be added, it can be dangerous to use (see https://github.com/orgs/community/discussions/25305#discussioncomment-3247405).
Yes, no exception should be made in order to allow the actions user to push to protected branches, because this allows for other loopholes to appear.
Apparently, releases.yml and prettier.yml need to be adjusted.
I'll create a draft tomorrow. It might be useful to know the desired protection settings for the main branch, so we know the exact restrictions @eddiejaoude
Thanks everyone for your help on this 💪
I think the main rule should be Require a pull request before merging this stops anyone by mistake (especially me 😂 ) accidentally pushing to the main branch and breaking production