BioDrop icon indicating copy to clipboard operation
BioDrop copied to clipboard

[DOCS] Contributing section in docs for conventional commits style

Open eddiejaoude opened this issue 2 years ago • 3 comments

Description

I think in the docs it would be useful to have a section on our commits convention and a link to conventional commits website

https://linkfree.eddiehub.io/docs

Screenshots

No response

Additional information

No response

eddiejaoude avatar Jan 02 '23 13:01 eddiejaoude

It's great having you contribute to this project

Welcome to the community :nerd_face:

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

github-actions[bot] avatar Jan 02 '23 13:01 github-actions[bot]

@eddiejaoude can i work on this!

khanjasir90 avatar Jan 03 '23 06:01 khanjasir90

Sure 👍

eddiejaoude avatar Jan 03 '23 10:01 eddiejaoude

@eddiejaoude can i work on this!

Hey @khanjasir90 do you need any help with this?

ChinmayMhatre avatar Jan 27 '23 06:01 ChinmayMhatre

I had a doubt, for each issue raised do we have to get it assigned or can we directly start working on it and raise a PR, help me out as I am figuring out how open source community works

prasadj2003 avatar Jan 28 '23 08:01 prasadj2003

I had a doubt, for each issue raised do we have to get it assigned or can we directly start working on it and raise a PR, help me out as I am figuring out how open source community works

@predatorprasad yes it is best to have issues assigned. Please also take a look at the labels. For example, when an issue is ready to be worked on it will have the label status: ready for dev.

SaraJaoude avatar Feb 03 '23 14:02 SaraJaoude

Unassigned due to no recent activity.

SaraJaoude avatar Feb 03 '23 14:02 SaraJaoude

Thanks a lot for your reply

On Fri, 3 Feb 2023, 8:17 pm Sara Jaoude, @.***> wrote:

Unassigned due to no recent activity.

— Reply to this email directly, view it on GitHub https://github.com/EddieHubCommunity/LinkFree/issues/2583#issuecomment-1415976455, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWTOXRMRKTOG2ME7CSSKEN3WVULAHANCNFSM6AAAAAATOZWY4A . You are receiving this because you were mentioned.Message ID: @.***>

prasadj2003 avatar Feb 03 '23 15:02 prasadj2003

Hi, can I work on this?

sansarmaske avatar Feb 06 '23 05:02 sansarmaske

I have assigned it to you @sansarmaske

SaraJaoude avatar Feb 06 '23 05:02 SaraJaoude

Thanks! I will get started on this.

sansarmaske avatar Feb 06 '23 06:02 sansarmaske

Quick question, should I directly link to Conventional Commits website upon clicking on this section or should we have a page for this like the rest of the others? Also, is the description good enough? Please have a look at the screenshot below: Screen Shot 2023-02-06 at 12 17 00

sansarmaske avatar Feb 06 '23 06:02 sansarmaske

I think we should have a page like the others called Commit Style and the file name can be commits.

As to the description we can have:

On EddieHub repos we use Conventional Commits standard. This allows us to create a changelog from the commits.

Within the page it would be good to show some basic examples and then also have the link to the Conventional Commits website.

SaraJaoude avatar Feb 06 '23 08:02 SaraJaoude

Thank you for the explanation. I will work on this as you suggested.

sansarmaske avatar Feb 06 '23 09:02 sansarmaske

Pull Request merged

eddiejaoude avatar Feb 11 '23 04:02 eddiejaoude