BioDrop icon indicating copy to clipboard operation
BioDrop copied to clipboard

implemented typewriter effect using typewriter-effect package

Open RohitYandigeri opened this issue 3 years ago • 2 comments

workerB

Fixes Issue

enhances the webpage

Changes proposed

Check List (Check all the applicable boxes)

  • [ x] My code follows the code style of this project.
  • [ x] My change requires changes to the documentation.
  • [ x] I have updated the documentation accordingly.
  • [x ] All new and existing tests passed.
  • [ x] This PR does not contain plagiarized content.
  • [ x] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

https://user-images.githubusercontent.com/91059418/196380717-a91627c7-188a-4b11-af67-6bab54c26dbe.mp4

RohitYandigeri avatar Oct 18 '22 08:10 RohitYandigeri

Welcome @RohitYandigeri! Thank you so much for your first pull request!

github-actions[bot] avatar Oct 18 '22 08:10 github-actions[bot]

Thank you for the contribution 👍

Ideally you should raise an issue first to discuss the idea. TBH I am not a huge fan of the typewriter effect, I feel it is over used, plus it is not inclusive or accessible - but I am no expert in accessibility, @EmmaDawsonDev what do you think?

eddiejaoude avatar Oct 19 '22 06:10 eddiejaoude

Thank you for the contribution 👍

Ideally you should raise an issue first to discuss the idea. TBH I am not a huge fan of the typewriter effect, I feel it is over used, plus it is not inclusive or accessible - but I am no expert in accessibility, @EmmaDawsonDev what do you think?

How about I build another more creative animation and it may look way cooler than this !

RohitYandigeri avatar Oct 19 '22 13:10 RohitYandigeri

Any animation created also needs a way to pause, stop or hide it and you would also need to use the prefers reduced motion media query so that the animation doesn’t start for people who have it set to true

EmmaDawsonDev avatar Oct 19 '22 13:10 EmmaDawsonDev

Any animation created also needs a way to pause, stop or hide it and you would also need to use the prefers reduced motion media query so that the animation doesn’t start for people who have it set to true

Can you explain me in more simple way what actually I should work upon ?

RohitYandigeri avatar Oct 19 '22 13:10 RohitYandigeri