BioDrop icon indicating copy to clipboard operation
BioDrop copied to clipboard

[FEATURE] Add React components and pages to Storybook

Open eddiejaoude opened this issue 2 years ago • 12 comments

Description

All React components and pages need to be added to Storybook (in the nextjs branch)

Note Each item listed below for component/page should be in a new Issue and PR

  • [x] components/user/UserLink.js https://github.com/EddieHubCommunity/LinkFree/blob/nextjs/stories/components/user/UserLink.stories.js
  • [x] components/user/UserMilestone.js https://github.com/EddieHubCommunity/LinkFree/blob/nextjs/stories/components/user/UserMilestone.stories.js
  • [ ] components/user/UserPreview.js
  • [ ] components/navbar/NavLink.js
  • [ ] components/navbar/Navbar.js
  • [x] components/footer.js
  • [x] pages/[username].js https://github.com/EddieHubCommunity/LinkFree/blob/nextjs/stories/pages/%5Busername%5D.stories.js
  • [ ] pages/index.js
  • [ ] pages/popular.js
  • [ ] pages/search.js

Steps to follow...

  1. Create story file in stories/components with the same filename as the component but add .stories.js
  2. Import the component into the story file
  3. Set the default arguments by looking at the requirements from the component
  4. Run npm run storybook to see the added components and interact with them

Screenshots

Screenshot 2022-10-11 at 13 25 41

Additional information

No response

eddiejaoude avatar Oct 11 '22 12:10 eddiejaoude

It's great having you contribute to this project

Welcome to the community :nerd_face:

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

github-actions[bot] avatar Oct 11 '22 12:10 github-actions[bot]

hi @eddiejaoude , you can assign this to me

manav-06 avatar Oct 11 '22 12:10 manav-06

Each item listed below for component/page should be in a new Issue and PR

Please create an issue for the item in the list that you want to do and we can assign that to you @manav-06

eddiejaoude avatar Oct 11 '22 13:10 eddiejaoude

Hi can I contribute in this project

DeeptanshuDas avatar Oct 12 '22 14:10 DeeptanshuDas

Hi @eddiejaoude , I want to contribute to:

components/navbar/NavLink.js

Is it open to contribute?

Prasundas99 avatar Oct 12 '22 19:10 Prasundas99

I never user storybook but I can do this live today, if you assign this to me

FrancescoXX avatar Oct 13 '22 05:10 FrancescoXX

Yes @DeeptanshuDas @Prasundas99 yes, great 👍

eddiejaoude avatar Oct 13 '22 09:10 eddiejaoude

@FrancescoXX that is awesome 👍 We are not assign this issue, because it is a collection of many issues, so you can pick one from the list in the issue description - there are actually many more to do, I can update the list in the issue description

eddiejaoude avatar Oct 13 '22 09:10 eddiejaoude

Hi, I can add the "popular" page.

itsagift avatar Oct 13 '22 12:10 itsagift

Hello @eddiejaoude , I want to work on pages/search.js.

RKC3000 avatar Oct 15 '22 17:10 RKC3000

@RKC3000 great, please create an issue and PR for that specific story 🤓

eddiejaoude avatar Oct 16 '22 01:10 eddiejaoude

OK @eddiejaoude

Can you clear me on one thing?

To contribute I have to follow docs/CONTRIBUITING.md

I not that use to work with issues and contribute on GitHub

RKC3000 avatar Oct 16 '22 06:10 RKC3000

Hey, @eddiejaoude can you assign this components/user/UserPreview.js issue to me? Thanks

MAX-786 avatar Oct 21 '22 17:10 MAX-786

@MAX-786 what is the issue number?

eddiejaoude avatar Oct 21 '22 17:10 eddiejaoude

@eddiejaoude #2012 can you please assign it?

MAX-786 avatar Oct 21 '22 18:10 MAX-786

@MAX-786 the footer component has already been checked off the list

eddiejaoude avatar Oct 21 '22 22:10 eddiejaoude

okay @eddiejaoude , is there any left where i can contrubute?

MAX-786 avatar Oct 23 '22 09:10 MAX-786

Yes there are @MAX-786 , you can check in the stories folder https://github.com/EddieHubCommunity/LinkFree/tree/nextjs/stories

eddiejaoude avatar Oct 23 '22 10:10 eddiejaoude

thanks @eddiejaoude, I will surely do that.

MAX-786 avatar Oct 23 '22 16:10 MAX-786

I will close this EPIC and people can create new issues for each Story

eddiejaoude avatar Nov 06 '22 22:11 eddiejaoude