BioDrop icon indicating copy to clipboard operation
BioDrop copied to clipboard

[FEATURE] Move from Cypress to Playwright

Open eddiejaoude opened this issue 3 years ago • 6 comments

Description

Currently the tests are written in Cypress with Cucumber, however these need to be moved to Playwright (similar to the Finder project)

http://playwright.dev

Warning this is for the nextjs branch

Note You don't need to do all the tests, different people can do individual tests in a new PR

Screenshots

No response

Additional information

No response

eddiejaoude avatar Oct 07 '22 22:10 eddiejaoude

It's great having you contribute to this project

Welcome to the community :nerd_face:

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

github-actions[bot] avatar Oct 07 '22 22:10 github-actions[bot]

Hey Eddie 🙋🏻‍♂️ is no one is on this issue, I would be happy to do it.

I've been meaning to play around with Playwright, and this seems like a good opportunity.

Thanks and cool project 👍🏻

petercr avatar Oct 10 '22 02:10 petercr

Hi Peter, sure sounds great 👍

Btw I can't assign it to you as you are not part of the EddieHub Org, steps to getting started are in our GitHub Org

eddiejaoude avatar Oct 13 '22 04:10 eddiejaoude

Eddie,

Okay I went and joined the EddieHub so I should be good to go with the Org and the assignment 👍🏻

I'll go ahead and start planning this one out.

Thanks

petercr avatar Oct 15 '22 02:10 petercr

Thanks @petercr , please create the issue for the test you will do, and we can assign that to you - this issue is an epic and won't be assigned as it is too big and will be broken down into smaller issues

eddiejaoude avatar Oct 15 '22 07:10 eddiejaoude

Thanks Eddie 🙌🏻 yeah this does seem like it might be a little big for just one issue/PR.

Then I'd have to think of if you wanted me to squash the 18 commits in that PR... 😂

I will just open an issue for a specific test and make a PR for that issue 👍🏻

petercr avatar Oct 15 '22 17:10 petercr

Eddie,

It looks like there is an implementation of Cucumber and Playwright together already on GitHub && NPM. Link to the cucumber-playwright repo

There is the possibility that we could port all of the existing cypress tests written in cucumber and just switch out cypress for playwright. Instead of re-writing all the tests.

Is that something you would be interested in, or would you rather go the route of re-writing the tests from scratch? Either way works 👍

Thanks

petercr avatar Oct 19 '22 21:10 petercr

Thanks Peter for doing that research. The community were not keen on Cucumber, so we decided to rewrite using vanilla Playwrght

eddiejaoude avatar Oct 19 '22 23:10 eddiejaoude

Awesome 👍🏻 cucumber looks great... but if you are used to writing tests in JS/TS it does seems like an extra step.

If you can write the tests, you probably should write the tests 😂

Thanks for all the info 🙌🏻

petercr avatar Oct 20 '22 16:10 petercr

I am going to close this epic, there are still more tests to be written though

eddiejaoude avatar Nov 06 '22 22:11 eddiejaoude