BioDrop icon indicating copy to clipboard operation
BioDrop copied to clipboard

links property is not optional. generate.js breaks when links are not defined.

Open kalijonn opened this issue 2 years ago • 3 comments

Description

Hi,

README says that links is optional. But not having 'links' property at all, breaks generate.js. Looks like this is addressed in ProfilePage where we check if 'links' exist before mapping.

This currently doesn't break because there are no profiles without the 'links' property.

Also, upon further inspection, I've noticed that the 'linkCount' property generated is unused. This was implemented as a part of user profiles in home page. However, as a part of #1264 this was removed.

If the idea is to reimplement linkCount, we can keep it while adding an optional flag during generation. If not, we can remove it entirely.

Let me know what you think.

Screenshots

No response

Additional information

No response

kalijonn avatar May 28 '22 07:05 kalijonn

It's great having you contribute to this project

Welcome to the community :nerd_face:

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

github-actions[bot] avatar May 28 '22 07:05 github-actions[bot]

Hello there, I like your suggestion. I have already notice about that issue and I'd like to work to solve it if possible.

SquatCub avatar Jul 05 '22 19:07 SquatCub

This is LinkFree, where we can share our links in one place, if there will be no links, then why would anyone like to use these apps?

will update the readme.MD

kabir0x23 avatar Aug 15 '22 16:08 kabir0x23