BioDrop icon indicating copy to clipboard operation
BioDrop copied to clipboard

[FEATURE] Add Showwcase Icon

Open vikasganiga05 opened this issue 3 years ago • 13 comments
trafficstars

Description

We can add the Showwcase in the social icons. Showwcase is a professional network built for developers to connect, build community, and find new opportunities.

Screenshots

It's a showwcase profile page of Tapas Adhikary

showwcase profile page

Additional information

I found this logo from Showwcase About Page format (webp) Showwcase Logo

vikasganiga05 avatar Jan 28 '22 14:01 vikasganiga05

It's great having you contribute to this project

Welcome to the community :nerd_face:

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

github-actions[bot] avatar Jan 28 '22 14:01 github-actions[bot]

I want to work on this issue can you assign me @emmalearnscode

vasantisuthar avatar Jan 28 '22 15:01 vasantisuthar

Sure. When adding an icon it needs adding in 3 places.

  1. It needs importing from react icons and adding to the switch in GetIcons.js,
  2. it needs a color code adding in config/links.json
  3. and it needs adding to the readme.

The first 2 files are in alphabetical order, readme is not yet ordered so it can be placed anywhere.

EmmaDawsonDev avatar Jan 28 '22 16:01 EmmaDawsonDev

Hey, @vasantisuthar Do you need any help with this? Let me know.

vikasganiga05 avatar Jan 31 '22 14:01 vikasganiga05

Hey @vikasganiga05, Looks like their PR has been merged already, this issue hasn't been closed yet, so could you or one of the maintainers, do the neatful?

gptkrsh avatar Jan 31 '22 14:01 gptkrsh

Hey @vikasganiga05, Looks like their PR has been merged already, this issue hasn't been closed yet, so could you or one of the maintainers, do the neatful?

No, The showwcase icon is not added to README.md, src/config/links.json and src/Components/Icons/GetIcons.js.

vikasganiga05 avatar Jan 31 '22 15:01 vikasganiga05

I got confused because of the merged PR mentioned 😅 Sorry about that.

gptkrsh avatar Jan 31 '22 15:01 gptkrsh

hey @vikasganiga05, I am working on it, if I ran into any issue, I'll ask. Thanks

vasantisuthar avatar Jan 31 '22 17:01 vasantisuthar

I got confused because of the merged PR mentioned sweat_smile Sorry about that.

It's okay. :smile:

vikasganiga05 avatar Jan 31 '22 18:01 vikasganiga05

hey @vikasganiga05, I am working on it, if I ran into any issue, I'll ask. Thanks

That sounds great :+1:

vikasganiga05 avatar Jan 31 '22 19:01 vikasganiga05

@vasantisuthar are you still working on this?

schmelto avatar Feb 28 '22 13:02 schmelto

The showwcase icon is not on any font illustration platform so I have created an issue in font-awesome for the icon to be added. Here is the link to the issue https://github.com/FortAwesome/Font-Awesome/issues/18631, and we can vote it so the icon can be added shortly.

vasantisuthar avatar Feb 28 '22 14:02 vasantisuthar

The showwcase icon is not on any font illustration platform so I have created an issue in font-awesome for the icon to be added. Here is the link to the issue FortAwesome/Font-Awesome#18631, and we can vote it so the icon can be added shortly.

You can use this:- https://www.showwcase.com/favicon.ico This will help you to get the showwcase icon.

Susmita-Dey avatar Apr 07 '22 14:04 Susmita-Dey

Hello @vikasganiga05 , I see the issue is not closed. Is any work still pending here, if Yes I would like to work on it.

Thanks!

ayushhagarwal avatar Nov 01 '22 08:11 ayushhagarwal

2 PRs have been merged, so I think this issue is now complete.

eddiejaoude avatar Nov 05 '22 23:11 eddiejaoude