BioDrop icon indicating copy to clipboard operation
BioDrop copied to clipboard

[BUG] Add Hover Effect for Explaining Uneditable Links

Open ThomasCode92 opened this issue 1 year ago • 9 comments

Has this bug been raised before?

  • [X] I have checked "open" AND "closed" issues and this is not a duplicate

Where did you find this bug?

Production

Version of BioDrop (for example "v1.2.3")

v2.99.12

Description

When users attempt to edit a link of their profile, there is no feedback or explanation provided for why the link cannot be edited. This lack of information can lead to confusion, especially for new users.

Proposed Solution Implement a hover effect on uneditable links that triggers a tooltip or a small pop-up, providing a clear explanation for why the link cannot be edited. This enhancement will improve user experience and help users understand the constraints on link editing.

Steps to Reproduce

  1. Go to your profile page.
  2. In the center, click Edit in Links tab
  3. Click the edit button of any link.
  4. Try editting the url of the link

Screenshots

image

Do you want to work on this issue?

No

If "yes" to above, please explain how you would technically implement this

No response

ThomasCode92 avatar Feb 02 '24 23:02 ThomasCode92

To reduce notifications, issues are locked until they are https://github.com/EddieHubCommunity/BioDrop/labels/%F0%9F%8F%81%20status%3A%20ready%20for%20dev and to be assigned. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

github-actions[bot] avatar Feb 02 '24 23:02 github-actions[bot]

@ThomasCode92 great idea, what would be the mobile experience?

ℹ️ amandamartin-dev has some opened assigned issues: 🔧View assigned issues

amandamartin-dev avatar Feb 03 '24 15:02 amandamartin-dev

Maybe we can show some sort of helper text below (or above) the input?

ℹ️ ThomasCode92 has some opened assigned issues: 🔧View assigned issues

ThomasCode92 avatar Feb 03 '24 16:02 ThomasCode92

Maybe we can show some sort of helper text below (or above) the input?

That could be a good solution for both experiences perhaps? Will add the discussion tag so others can weigh in on the best way to approach too. Thank you for your thoughts.

amandamartin-dev avatar Feb 03 '24 16:02 amandamartin-dev

May be we can use lock icons to visually indicate that it is not editable

manassingh17 avatar Feb 03 '24 20:02 manassingh17

I guess tooltip will work better for new users.

pranay-dutta avatar Feb 19 '24 19:02 pranay-dutta

Can I work on this issue @ThomasCode92 @amandamartin-dev , My approach is pretty simple add a title attribute in the input field will do the work

SohamRoy-01 avatar Mar 24 '24 19:03 SohamRoy-01

@SohamRoy-01, you'll need to direct your inquiry to one of the maintainers. As for me, feel free to proceed with your work, but I lack the authority to make decisions as I'm not a maintainer.

ThomasCode92 avatar Mar 25 '24 08:03 ThomasCode92

Ok @ThomasCode92. Can I work on this issue @eddiejaoude ?

SohamRoy-01 avatar Mar 26 '24 15:03 SohamRoy-01

hello @ThomasCode92, I am saying the link should be editable because users can enter a wrong link, so they may want to try to fix it.

BamaCharanChhandogi avatar Apr 22 '24 07:04 BamaCharanChhandogi

@BamaCharanChhandogi I am saying the link should be editable because users can enter a wrong link, so they may want to try to fix it.

This will confusion with the stats, that is why we make it uneditable - they can create a new link in their profile

@SohamRoy-01 My approach is pretty simple add a title attribute in the input field will do the work

Simple is good, we can make it fancier if required later on

@SohamRoy-01 I will assign it to you, thanks

eddiejaoude avatar Apr 22 '24 10:04 eddiejaoude

The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

github-actions[bot] avatar Apr 22 '24 10:04 github-actions[bot]

hey, @eddiejaoude I am also available if @SohamRoy-01 doesn't want to work.

BamaCharanChhandogi avatar Apr 22 '24 12:04 BamaCharanChhandogi

Thanks for assigning @eddiejaoude I will work on it .

ℹ️ SohamRoy-01 has some opened assigned issues: 🔧View assigned issues

SohamRoy-01 avatar Apr 22 '24 14:04 SohamRoy-01