BioDrop icon indicating copy to clipboard operation
BioDrop copied to clipboard

[BUG] Duplicate sortable package present

Open ChinmayMhatre opened this issue 1 year ago • 14 comments

Has this bug been raised before?

  • [X] I have checked "open" AND "closed" issues and this is not a duplicate

Where did you find this bug?

Production

Version of BioDrop (for example "v1.2.3")

2.99.3

Description

I noticed two sortablejs and react-sortable packages. https://github.com/EddieHubCommunity/BioDrop/blob/main/package.json (Line 41 and 48 )

I searched for usage in the project But only found one being used in the project. image

https://github.com/search?q=repo%3AEddieHubCommunity/BioDrop%20%22sortablejs%22&type=code

P.S. One could depend on the other but wanted to raise a request just in case.

Steps to Reproduce

  • open the package.json file https://github.com/EddieHubCommunity/BioDrop/blob/main/package.json
  • line 41 and 48 have two different sortable packages.

Screenshots

No response

Do you want to work on this issue?

No

If "yes" to above, please explain how you would technically implement this

No response

ChinmayMhatre avatar Jan 13 '24 12:01 ChinmayMhatre

To reduce notifications, issues are locked until they are https://github.com/EddieHubCommunity/BioDrop/labels/%F0%9F%8F%81%20status%3A%20ready%20for%20dev and to be assigned. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

github-actions[bot] avatar Jan 13 '24 12:01 github-actions[bot]

Oh good spot, it looks like the sortablejs got added recently. I think it could be tested without this package and see if sorting works

eddiejaoude avatar Jan 18 '24 08:01 eddiejaoude

The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

github-actions[bot] avatar Jan 18 '24 13:01 github-actions[bot]

i would like to take this one

salisshuaibu11 avatar Jan 19 '24 01:01 salisshuaibu11

@salisshuaibu11 assigned it to you

ChinmayMhatre avatar Jan 20 '24 07:01 ChinmayMhatre

As it has been two weeks since this was assigned to you @salisshuaibu11 and as no PR has been created, I am unassigning this issue so that we can give someone else the opportunity to work on it.

SaraJaoude avatar Feb 04 '24 10:02 SaraJaoude

Hi. Could I work on this please? Thank you.

dreamycodex avatar Feb 13 '24 21:02 dreamycodex

@dreamycodex Assigned you the issue

ℹ️ ChinmayMhatre has some opened assigned issues: 🔧View assigned issues

ChinmayMhatre avatar Feb 14 '24 09:02 ChinmayMhatre

Hi, can I work on this issue? it is still assigned to someone but it's been a month and it is still unresolved.

harshwasthere avatar Mar 16 '24 14:03 harshwasthere

hello, can i be assigned to this issue?

eugene4545 avatar Apr 15 '24 06:04 eugene4545

@Harsh12Codes I couldn't see a PR either, so yes we can reassign it to you as 2 weeks has past since being assigned

ℹ️ eddiejaoude has some opened assigned issues: 🔧View assigned issues

eddiejaoude avatar Apr 22 '24 10:04 eddiejaoude

@eddiejaoude I found out that react-sortable.js is dependent on sortable.js, so there is no duplicate to remove.

image

harshwasthere avatar Apr 24 '24 09:04 harshwasthere

hello, can i be assigned to this issue?

irungudennisnganga avatar May 03 '24 12:05 irungudennisnganga

@ChinmayMhatre:- Is this issue still needs to be kept open, as @Harsh12Codes confirms that both the packages are needed. As one of the package is dependent on the other package.

vinitmehta51 avatar May 03 '24 12:05 vinitmehta51