BioDrop
BioDrop copied to clipboard
[BUG] Duplicate sortable package present
Has this bug been raised before?
- [X] I have checked "open" AND "closed" issues and this is not a duplicate
Where did you find this bug?
Production
Version of BioDrop (for example "v1.2.3")
2.99.3
Description
I noticed two sortablejs and react-sortable packages. https://github.com/EddieHubCommunity/BioDrop/blob/main/package.json (Line 41 and 48 )
I searched for usage in the project But only found one being used in the project.
https://github.com/search?q=repo%3AEddieHubCommunity/BioDrop%20%22sortablejs%22&type=code
P.S. One could depend on the other but wanted to raise a request just in case.
Steps to Reproduce
- open the package.json file https://github.com/EddieHubCommunity/BioDrop/blob/main/package.json
- line 41 and 48 have two different sortable packages.
Screenshots
No response
Do you want to work on this issue?
No
If "yes" to above, please explain how you would technically implement this
No response
To reduce notifications, issues are locked until they are https://github.com/EddieHubCommunity/BioDrop/labels/%F0%9F%8F%81%20status%3A%20ready%20for%20dev and to be assigned. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md
Oh good spot, it looks like the sortablejs
got added recently. I think it could be tested without this package and see if sorting works
The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md
i would like to take this one
@salisshuaibu11 assigned it to you
As it has been two weeks since this was assigned to you @salisshuaibu11 and as no PR has been created, I am unassigning this issue so that we can give someone else the opportunity to work on it.
Hi. Could I work on this please? Thank you.
@dreamycodex Assigned you the issue
ℹ️ ChinmayMhatre has some opened assigned issues: 🔧View assigned issues
Hi, can I work on this issue? it is still assigned to someone but it's been a month and it is still unresolved.
hello, can i be assigned to this issue?
@Harsh12Codes I couldn't see a PR either, so yes we can reassign it to you as 2 weeks has past since being assigned
ℹ️ eddiejaoude has some opened assigned issues: 🔧View assigned issues
@eddiejaoude I found out that react-sortable.js
is dependent on sortable.js
, so there is no duplicate to remove.
hello, can i be assigned to this issue?
@ChinmayMhatre:- Is this issue still needs to be kept open, as @Harsh12Codes confirms that both the packages are needed. As one of the package is dependent on the other package.