Edan Toledo

Results 81 comments of Edan Toledo

So to finally close this issue, I'm pretty sure the current GAE calculation is correct. We have provided both the old API and the new API so that if a...

whats the state on this?

Is this done now and ready for review?

I think there is probably a way of handling this generically and for future features such as this, maybe there is a way to handle things with environment wrappers and...

Hey, this is strange, are you using the latest main branch? I often have detailed logging off - so its very possible there is some edge case i have not...

Hey, yeah i am aware of this actually. See https://github.com/EdanToledo/Stoix/issues/142 for GAE calc. Basically, i fixed it for GAE calculation but it requires a specific way of inputting the data....

Yeah, its not the most optimal set up unfortunately but having dummy rewards and actions introduces a whole other can of worms and would require significant changes to all the...

will get to this when stoa PR is finished

@Michael-Beukman Putting this here - i am still interested in doing this.