EdJoPaTo

Results 355 comments of EdJoPaTo

It still seems to happen sometimes but I cant really pinpoint why. I assume keeping it open and then ignoring the device for quite some time. But thats only a...

To add some maybe helpful information: This was introduced with the `!Tag` syntax of `0.9`. Using `serde_yaml` with `0.8` works perfectly fine with `#[serde(flatten)]`.

Just to add a thought in here: Maybe a `noStyle` setting (similar to `indent` or `semicolon`) would be nice so people can use own formatters easier.

I got a bunch of claim parsing typed which is nice. On the downside: I'm not sure how much I like the simplify methods as they are very dependent on...

This is horrible to review… Maybe I should split this up into multiple Pull Requests which can be reviewed and accepted on their own. I keep this one open and...

There are still some things left which are not added in their own PR… I scrolled over this PR and found these: - [ ] eslint → eslint-with-typescript (probably should...

you probably want to set the instance argument to the actual instance? or did you change it here to some dummy value? When interested in wikidata you need to import...

The idea of wikibase-sdk is to connect to an existing Wikibase instance. For example Wikidata is one Wikibase instance. (You can of course host your own Wikibase instance but thats...

Maybe even remove the richVal logic? Having the exact names of variables as in the query is also simple and results in way less checks / assumptions of the returning...

As this library is completely without async / Promises the uncaught promise error is unrelated to this library. Using try catch and await is way easier to manage than your...