Edward Haas

icon indicating an email [email protected]

icon location Israel

Results 199 comments of Edward Haas

network, binding: Declare the SLIRP core binding as deprecated and remove it

> Great work! looks good to me overall. > > Regarding `virt-controller: Add network validation for the VM and VMI controllers` commit message these a typo at first line `Ad`...

network, binding: Declare the SLIRP core binding as deprecated and remove it

[change](https://github.com/kubevirt/kubevirt/compare/ce7bcfdb85074bf7af7941017979f5a028fd1d57..8fc69fab18622285dd028768dddeb66e0e441a0a): rebase and fixed commit message typo based on review. [change](https://github.com/kubevirt/kubevirt/compare/8fc69fab18622285dd028768dddeb66e0e441a0a..539b23731fd1a308dc8894be89d8d101a7c5963b): Rebase

network, binding: Declare the SLIRP core binding as deprecated and remove it

change: Rebase

network, binding: Declare the SLIRP core binding as deprecated and remove it

> > New VMs should use the alternatives: The bridge binding [4], passt binding plugin [1] or the (less recommended) slirp binding plugin [3]. > > masquerade is missing. `bridge`...

network, binding: Declare the SLIRP core binding as deprecated and remove it

change: Rebase

network, binding: Declare the SLIRP core binding as deprecated and remove it

[change](https://github.com/kubevirt/kubevirt/compare/3bfd4770ebb06a07a0dbb808ebaebc7de77759a3..5673edbe31372e6ab00435852f3d92e38442d3b0): Answered review comments.

network, binding: Declare the SLIRP core binding as deprecated and remove it

/test pull-kubevirt-e2e-k8s-1.30-sig-compute

network, binding: Declare the SLIRP core binding as deprecated and remove it

/test pull-kubevirt-fossa

network, binding: Declare the SLIRP core binding as deprecated and remove it

/test pull-kubevirt-e2e-k8s-1.30-ipv6-sig-network

network, binding: Declare the SLIRP core binding as deprecated and remove it

/test pull-kubevirt-e2e-k8s-1.30-ipv6-sig-network