Edward Haas

Results 199 comments of Edward Haas

> Correct me if I'm wrong @EdDev, but an `IPAM` interface - where whereabouts is only one type of provider - would address your concerns. How it would look like...

The production code is not suppose to depend on CDI AFAIK. Is this correct? I am pretty sure the e2e tests do depend on it. Anyway, this is a major...

> Still there IIUC, just brought in official https://github.com/kubevirt/containerized-data-importer/blob/main/vendor/libguestfs.org/libnbd/aio_buffer.go#L5 It changed from GPL to LGPL. But I think it is in a gray area. Ref: https://www.apache.org/legal/resolved.html#category-x

> It changed from GPL to LGPL. But I think it is in a gray area. Ref: https://www.apache.org/legal/resolved.html#category-x We just need to make sure it is not vendored in, that...

/test pull-kubevirt-generate /test pull-kubevirt-build /test pull-kubevirt-e2e-kind-1.22-sriov-nonroot

@tgfree7 , I am unsure if we as a project want to support such old nodes. It seems to me like a heavy maintenance burden to take. There was also...

> The more I look at this, I think we need two different ways to build vmi, > > * set some values (maybe override) using `WithSomething` > * add...

> @EdDev Overriding means not panicking and keeping the current behavior? I see it as a problem for example when you want to change the `bus` of an existing disk....

Like: panic if the value (not the key) is different. But not if it is the same.

I'm getting back to this after too much time. @vladikr , in our last discussion on this matter, per what I remember, we agreed that I will also add this...